From c34f49faae5ebb83a759953008dc5cd6338022b9 Mon Sep 17 00:00:00 2001 From: Rafael Moraes <50295204+glomatico@users.noreply.github.com> Date: Thu, 6 Nov 2025 15:49:20 -0300 Subject: [PATCH] Rename song codec CLI option for consistency --- README.md | 2 +- gamdl/cli/cli.py | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 27e1323..6c96a7a 100644 --- a/README.md +++ b/README.md @@ -150,7 +150,7 @@ The file is created automatically on first run. Command-line arguments override | `--cover-size` | Cover size in pixels | `1200` | | `--truncate` | Max filename length | - | | **Song Options** | | | -| `--codec-song` | Song codec | `aac-legacy` | +| `--song-codec` | Song codec | `aac-legacy` | | `--synced-lyrics-format` | Synced lyrics format | `lrc` | | `--no-synced-lyrics` | Don't download synced lyrics | `false` | | `--synced-lyrics-only` | Download only synced lyrics | `false` | diff --git a/gamdl/cli/cli.py b/gamdl/cli/cli.py index 00010b7..7e28c9e 100644 --- a/gamdl/cli/cli.py +++ b/gamdl/cli/cli.py @@ -286,7 +286,7 @@ def make_sync(func): ) # DownloaderSong specific options @click.option( - "--codec-song", + "--song-codec", type=SongCodec, default=song_downloader_sig.parameters["codec"].default, help="Song codec", @@ -377,7 +377,7 @@ async def main( exclude_tags: list[str], cover_size: int, truncate: int, - codec_song: SongCodec, + song_codec: SongCodec, synced_lyrics_format: SyncedLyricsFormat, no_synced_lyrics: bool, synced_lyrics_only: bool, @@ -465,7 +465,7 @@ async def main( song_downloader = AppleMusicSongDownloader( base_downloader=base_downloader, interface=song_interface, - codec=codec_song, + codec=song_codec, synced_lyrics_format=synced_lyrics_format, no_synced_lyrics=no_synced_lyrics, synced_lyrics_only=synced_lyrics_only, @@ -503,7 +503,7 @@ async def main( if ( not base_downloader.full_mp4decrypt_path - and codec_song + and song_codec not in ( SongCodec.AAC_LEGACY, SongCodec.AAC_HE_LEGACY, @@ -530,7 +530,7 @@ async def main( ) downloader.skip_music_videos = True - if not codec_song.is_legacy(): + if not song_codec.is_legacy(): logger.warning( "You have chosen an experimental song codec. " "They're not guaranteed to work due to API limitations."