From 39623b90bd0846ac2316395143a73a3340e2dfd3 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Mon, 8 Jun 2026 22:30:19 -0400 Subject: [PATCH] fix: Search prop is optional --- app/editor/components/EmojiMenu.tsx | 2 +- app/editor/components/MentionMenu.tsx | 2 +- app/editor/components/SuggestionsMenu.tsx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/editor/components/EmojiMenu.tsx b/app/editor/components/EmojiMenu.tsx index 62de2dfd1f..dae085cbbc 100644 --- a/app/editor/components/EmojiMenu.tsx +++ b/app/editor/components/EmojiMenu.tsx @@ -25,7 +25,7 @@ type Props = Omit< const EmojiMenu = (props: Props) => { const { emojis } = useStores(); - const { search } = props; + const { search = "" } = props; useEffect(() => { if (search) { diff --git a/app/editor/components/MentionMenu.tsx b/app/editor/components/MentionMenu.tsx index f8026bdf8e..e472d96101 100644 --- a/app/editor/components/MentionMenu.tsx +++ b/app/editor/components/MentionMenu.tsx @@ -47,7 +47,7 @@ type Props = Omit< "renderMenuItem" | "items" | "embeds" >; -function MentionMenu({ search, isActive, ...rest }: Props) { +function MentionMenu({ search = "", isActive, ...rest }: Props) { const [loaded, setLoaded] = useState(false); const { t } = useTranslation(); const { auth, documents, users, collections, groups } = useStores(); diff --git a/app/editor/components/SuggestionsMenu.tsx b/app/editor/components/SuggestionsMenu.tsx index d298b2c172..d1a497f7e1 100644 --- a/app/editor/components/SuggestionsMenu.tsx +++ b/app/editor/components/SuggestionsMenu.tsx @@ -35,7 +35,7 @@ import { MenuHeader } from "~/components/primitives/components/Menu"; export type Props = { rtl: boolean; isActive: boolean; - search: string; + search?: string; trigger: string | string[]; uploadFile?: (file: File) => Promise; onFileUploadStart?: () => void; @@ -400,7 +400,7 @@ function SuggestionsMenu(props: Props) { }; const filtered = React.useMemo(() => { - const { embeds = [], search, uploadFile, filterable = true } = props; + const { embeds = [], search = "", uploadFile, filterable = true } = props; let items: (EmbedDescriptor | MenuItem)[] = [...props.items]; const embedItems: EmbedDescriptor[] = [];