From 5439afa5c8629c00ca777a1f11bdc7bcbbbc1ca3 Mon Sep 17 00:00:00 2001
From: Tom Moor <tom@getoutline.com>
Date: Sun, 1 Mar 2026 20:12:52 -0500
Subject: [PATCH] fix: Minor language and position tweaks

---
 app/components/Switch.tsx                           |  7 ++++---
 app/hooks/useSettingsConfig.ts                      | 13 ++++++-------
 app/scenes/Document/components/DocumentMeta.tsx     |  7 ++++++-
 app/scenes/Search/Search.tsx                        |  3 ++-
 .../Settings/{APIAndApps.tsx => APIAndAccess.tsx}   | 12 ++++++------
 shared/i18n/locales/en_US/translation.json          |  2 +-
 6 files changed, 25 insertions(+), 19 deletions(-)
 rename app/scenes/Settings/{APIAndApps.tsx => APIAndAccess.tsx} (93%)

diff --git a/app/components/Switch.tsx b/app/components/Switch.tsx
index aeccfa720e..f2cf660ef7 100644
--- a/app/components/Switch.tsx
+++ b/app/components/Switch.tsx
@@ -28,6 +28,7 @@ interface Props extends Omit<
   disabled?: boolean;
   /** Callback when the switch state changes */
   onChange?: (checked: boolean) => void;
+  inForm?: boolean;
 }
 
 function Switch(
@@ -71,7 +72,7 @@ function Switch(
 
   if (label) {
     return (
-      <Wrapper>
+      <Wrapper $inForm={props.inForm}>
         <Label
           disabled={disabled}
           htmlFor={props.id}
@@ -100,8 +101,8 @@ function Switch(
   return component;
 }
 
-const Wrapper = styled.div`
-  padding-bottom: 8px;
+const Wrapper = styled.div<{ $inForm?: boolean }>`
+  padding-bottom: ${(props) => (props.$inForm ? 8 : 0)}px;
   ${undraggableOnDesktop()}
 `;
 
diff --git a/app/hooks/useSettingsConfig.ts b/app/hooks/useSettingsConfig.ts
index f554c503f4..ef33844015 100644
--- a/app/hooks/useSettingsConfig.ts
+++ b/app/hooks/useSettingsConfig.ts
@@ -16,7 +16,6 @@ import {
   PlusIcon,
   InternetIcon,
   SmileyIcon,
-  BuildingBlocksIcon,
   BrowserIcon,
 } from "outline-icons";
 import { useEffect } from "react";
@@ -33,7 +32,7 @@ import useStores from "./useStores";
 
 const ApiKeys = lazy(() => import("~/scenes/Settings/ApiKeys"));
 const Applications = lazy(() => import("~/scenes/Settings/Applications"));
-const APIAndApps = lazy(() => import("~/scenes/Settings/APIAndApps"));
+const APIAndAccess = lazy(() => import("~/scenes/Settings/APIAndAccess"));
 const Authentication = lazy(() => import("~/scenes/Settings/Authentication"));
 const Details = lazy(() => import("~/scenes/Settings/Details"));
 const Export = lazy(() => import("~/scenes/Settings/Export"));
@@ -109,13 +108,13 @@ const useSettingsConfig = () => {
         icon: EmailIcon,
       },
       {
-        name: t("API & Apps"),
-        path: settingsPath("api-and-apps"),
-        component: APIAndApps.Component,
-        preload: APIAndApps.preload,
+        name: t("API & Access"),
+        path: settingsPath("api-and-access"),
+        component: APIAndAccess.Component,
+        preload: APIAndAccess.preload,
         enabled: true,
         group: t("Account"),
-        icon: BuildingBlocksIcon,
+        icon: PadlockIcon,
       },
       // Workspace
       {
diff --git a/app/scenes/Document/components/DocumentMeta.tsx b/app/scenes/Document/components/DocumentMeta.tsx
index 38d6eefcee..04431c1d50 100644
--- a/app/scenes/Document/components/DocumentMeta.tsx
+++ b/app/scenes/Document/components/DocumentMeta.tsx
@@ -60,7 +60,12 @@ function TitleDocumentMeta({ to, document, revision, ...rest }: Props) {
               pathname: documentPath(document as Document),
               state: { sidebarContext },
             }}
-            onClick={() => ui.set({ rightSidebar: "comments" })}
+            onClick={() =>
+              ui.set({
+                rightSidebar:
+                  ui.rightSidebar === "comments" ? null : "comments",
+              })
+            }
           >
             <CommentIcon size={18} />
             {commentsCount
diff --git a/app/scenes/Search/Search.tsx b/app/scenes/Search/Search.tsx
index e70f43deb2..e8bd20d93e 100644
--- a/app/scenes/Search/Search.tsx
+++ b/app/scenes/Search/Search.tsx
@@ -317,6 +317,7 @@ function Search() {
                     handleFilterChange({ titleFilter: checked });
                   }}
                   checked={titleFilter}
+                  inForm={false}
                 />
               )}
             </Flex>
@@ -420,9 +421,9 @@ const Filters = styled(HStack)`
 const SearchTitlesFilter = styled(Switch)`
   white-space: nowrap;
   margin-left: 8px;
-  margin-top: 8px;
   font-size: 14px;
   font-weight: 400;
+  height: 28px;
 `;
 
 export default observer(Search);
diff --git a/app/scenes/Settings/APIAndApps.tsx b/app/scenes/Settings/APIAndAccess.tsx
similarity index 93%
rename from app/scenes/Settings/APIAndApps.tsx
rename to app/scenes/Settings/APIAndAccess.tsx
index 3b89eccb01..808052bd3c 100644
--- a/app/scenes/Settings/APIAndApps.tsx
+++ b/app/scenes/Settings/APIAndAccess.tsx
@@ -1,5 +1,5 @@
 import { observer } from "mobx-react";
-import { BuildingBlocksIcon } from "outline-icons";
+import { PadlockIcon } from "outline-icons";
 import { useTranslation, Trans } from "react-i18next";
 import type ApiKey from "~/models/ApiKey";
 import type OAuthAuthentication from "~/models/oauth/OAuthAuthentication";
@@ -18,7 +18,7 @@ import useStores from "~/hooks/useStores";
 import ApiKeyListItem from "./components/ApiKeyListItem";
 import OAuthAuthenticationListItem from "./components/OAuthAuthenticationListItem";
 
-function APIAndApps() {
+function APIAndAccess() {
   const team = useCurrentTeam();
   const user = useCurrentUser();
   const { t } = useTranslation();
@@ -28,8 +28,8 @@ function APIAndApps() {
 
   return (
     <Scene
-      title={t("API & Apps")}
-      icon={<BuildingBlocksIcon />}
+      title={t("API & Access")}
+      icon={<PadlockIcon />}
       actions={
         <>
           {can.createApiKey && (
@@ -44,7 +44,7 @@ function APIAndApps() {
         </>
       }
     >
-      <Heading>{t("API & Apps")}</Heading>
+      <Heading>{t("API & Access")}</Heading>
       <h2>{t("API keys")}</h2>
       {can.createApiKey ? (
         <Text as="p" type="secondary">
@@ -98,4 +98,4 @@ function APIAndApps() {
   );
 }
 
-export default observer(APIAndApps);
+export default observer(APIAndAccess);
diff --git a/shared/i18n/locales/en_US/translation.json b/shared/i18n/locales/en_US/translation.json
index b389d0c152..39bf458f55 100644
--- a/shared/i18n/locales/en_US/translation.json
+++ b/shared/i18n/locales/en_US/translation.json
@@ -662,7 +662,7 @@
   "Unsubscribed from document": "Unsubscribed from document",
   "Unsubscribed from collection": "Unsubscribed from collection",
   "Account": "Account",
-  "API & Apps": "API & Apps",
+  "API & Access": "API & Access",
   "Details": "Details",
   "Authentication": "Authentication",
   "Security": "Security",