From 63668599351109a702f3b2515fc995160765c179 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Wed, 27 May 2026 23:18:37 -0400 Subject: [PATCH] chore: Remove Koa middleware span reporting (#12501) --- server/logging/tracer.ts | 4 ++++ server/onerror.ts | 9 --------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/server/logging/tracer.ts b/server/logging/tracer.ts index 439eecce4d..61c9bd4cdc 100644 --- a/server/logging/tracer.ts +++ b/server/logging/tracer.ts @@ -31,6 +31,10 @@ if (env.DD_API_KEY) { env: env.ENVIRONMENT, logInjection: true, }); + + // Disable per-middleware spans so that non-reportable errors are not captured + // This is also generally excessive noise + tracer.use("koa", { middleware: false }); } const getCurrentSpan = (): Span | null => tracer.scope().active(); diff --git a/server/onerror.ts b/server/onerror.ts index ed22f776ff..00ba281ab0 100644 --- a/server/onerror.ts +++ b/server/onerror.ts @@ -7,7 +7,6 @@ import { escape, isNil, snakeCase } from "es-toolkit/compat"; import env from "@server/env"; import { ClientClosedRequestError, InternalError } from "@server/errors"; import { requestErrorHandler } from "@server/logging/sentry"; -import { addTags, getRootSpanFromRequestContext } from "@server/logging/tracer"; let errorHtmlCache: Buffer | undefined; @@ -54,14 +53,6 @@ export default function onerror(app: Koa) { } err = InternalError(); } - } else { - // Clear error tags that dd-trace's Koa plugin sets automatically - // when an exception propagates through middleware, so that - // non-reportable errors are not flagged as errors in DataDog. - const span = getRootSpanFromRequestContext(this); - if (span) { - addTags({ error: false }, span); - } } const headerSent = this.headerSent || !this.writable;