From 7938ffdd7a5ee304731ae414aa25b3d3c8deaa4a Mon Sep 17 00:00:00 2001
From: Tom Moor <tom@getoutline.com>
Date: Sun, 7 Jun 2026 17:24:45 -0400
Subject: [PATCH] Restore SidebarButton position default to fix top padding
 regression (#12618)

The position prop is omitted at several call sites (App, Settings,
Shared sidebars) and relied on the top default for inset-titlebar
padding. Make the prop optional and restore the default so the lint
rule stays satisfied without changing runtime behavior.

Co-authored-by: Claude <noreply@anthropic.com>
---
 app/components/Sidebar/components/SidebarButton.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/components/Sidebar/components/SidebarButton.tsx b/app/components/Sidebar/components/SidebarButton.tsx
index 1bebb27268..1b2a43fe1c 100644
--- a/app/components/Sidebar/components/SidebarButton.tsx
+++ b/app/components/Sidebar/components/SidebarButton.tsx
@@ -11,7 +11,7 @@ import Desktop from "~/utils/Desktop";
 import { HStack } from "~/components/primitives/HStack";
 
 export type SidebarButtonProps = React.ComponentProps<typeof Button> & {
-  position: "top" | "bottom";
+  position?: "top" | "bottom";
   title: React.ReactNode;
   image: React.ReactNode;
   showMoreMenu?: boolean;
@@ -23,7 +23,7 @@ const SidebarButton = observer(
   React.forwardRef<HTMLButtonElement, SidebarButtonProps>(
     function SidebarButton_(
       {
-        position,
+        position = "top",
         showMoreMenu,
         image,
         title,