GitHub/outline
1
0
Fork 0
mirror of https://github.com/outline/outline.git synced 2026-06-13 11:25:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Search term highlights missing (#12598)

Browse Source
This commit is contained in:
Tom Moor
2026-06-05 17:57:09 -04:00
committed by GitHub
parent 0c0facc2a1
commit aad2483ff9
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/editor/extensions/FindAndReplace.tsx
+15 -2
View File
@@ -604,13 +604,26 @@ export default class FindAndReplaceExtension extends Extension<FindAndReplaceOpt
return { return {
update: (view) => { update: (view) => {
const generation = pluginKey.getState(view.state) as number; const generation = pluginKey.getState(view.state) as number;
if (generation !== lastGeneration) { // Rebuild highlights when the results change (generation bump) or,
// while a search is active, on any view update. The CSS Custom
// Highlight API relies on static DOM ranges that become detached
// when the editor re-renders its DOM — e.g. content settling after
// sync when navigating from search results, collaboration cursors,
// or node views mounting — none of which bump the generation. This
// keeps the highlights tracking the live DOM, as decorations do.
if (generation !== lastGeneration || this.searchTerm) {
lastGeneration = generation; lastGeneration = generation;
this.updateHighlights(); this.updateHighlights();
} }
}, },
destroy: () => { destroy: () => {
this.clearHighlights(); // The highlight registry is global and keyed by fixed names, so
// only tear down highlights when this editor actually owns an
// active search — otherwise an unmounting editor could wipe the
// highlights another editor just set during a route transition.
if (this.searchTerm) {
this.clearHighlights();
}
}, },
}; };
}, },