mirror of
https://github.com/outline/outline.git
synced 2026-06-13 11:25:03 +03:00
091346dfe8
* wip * Remove obsolete snapshots * simplify * chore(test): Convert mocks to TypeScript and tighten fetch mock types Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Remove unneccessary patches * Migrate to msw instead of custom fetch mock * Address PR review comments - Split chained vi.useFakeTimers().setSystemTime() into separate calls. - Switch test setup to dynamic imports so EventEmitter.defaultMaxListeners assignment runs before module init (static imports were hoisted above it). - Drop redundant NODE_ENV guard in monkeyPatchSequelizeErrorsForJest; its sole caller already gates on env.isTest. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
358 lines
10 KiB
TypeScript
358 lines
10 KiB
TypeScript
import { subHours } from "date-fns";
|
|
import { randomString } from "@shared/random";
|
|
import ShareDocumentUpdatedEmail from "@server/emails/templates/ShareDocumentUpdatedEmail";
|
|
import { ShareSubscription } from "@server/models";
|
|
import { buildDocument, buildShare } from "@server/test/factories";
|
|
import ShareSubscriptionNotificationsTask from "./ShareSubscriptionNotificationsTask";
|
|
|
|
const ip = "127.0.0.1";
|
|
|
|
beforeEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
describe("ShareSubscriptionNotificationsTask", () => {
|
|
it("should send email to confirmed subscriber", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const document = await buildDocument();
|
|
const share = await buildShare({
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("should not send email to unconfirmed subscriber", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const document = await buildDocument();
|
|
const share = await buildShare({
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should not send email to unsubscribed subscriber", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const document = await buildDocument();
|
|
const share = await buildShare({
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
unsubscribedAt: new Date(),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should throttle notifications to once per 6 hours", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const document = await buildDocument();
|
|
const share = await buildShare({
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
lastNotifiedAt: subHours(new Date(), 3),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should send if last notified more than 6 hours ago", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const document = await buildDocument();
|
|
const share = await buildShare({
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
lastNotifiedAt: subHours(new Date(), 7),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("should not send for unpublished shares", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const document = await buildDocument();
|
|
const share = await buildShare({
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
published: false,
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should update lastNotifiedAt after sending", async () => {
|
|
vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const document = await buildDocument();
|
|
const share = await buildShare({
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
});
|
|
const subscription = await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
});
|
|
|
|
expect(subscription.lastNotifiedAt).toBeNull();
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
await subscription.reload();
|
|
expect(subscription.lastNotifiedAt).not.toBeNull();
|
|
});
|
|
|
|
it("should send to multiple subscribers", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const document = await buildDocument();
|
|
const share = await buildShare({
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
});
|
|
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "sub1@example.com",
|
|
emailFingerprint: "sub1@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: document.id,
|
|
email: "sub2@example.com",
|
|
emailFingerprint: "sub2@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("should not send if document has no shares", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
const document = await buildDocument();
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: document.id,
|
|
teamId: document.teamId,
|
|
actorId: document.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should send when child document is updated and subscription is scoped to parent", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const parent = await buildDocument();
|
|
const child = await buildDocument({
|
|
parentDocumentId: parent.id,
|
|
collectionId: parent.collectionId,
|
|
teamId: parent.teamId,
|
|
});
|
|
const share = await buildShare({
|
|
documentId: parent.id,
|
|
teamId: parent.teamId,
|
|
includeChildDocuments: true,
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: parent.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: child.id,
|
|
teamId: child.teamId,
|
|
actorId: child.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("should not send when updated document is outside subscription scope", async () => {
|
|
const spy = vi.spyOn(ShareDocumentUpdatedEmail.prototype, "schedule");
|
|
|
|
const parent = await buildDocument();
|
|
const sibling = await buildDocument({
|
|
collectionId: parent.collectionId,
|
|
teamId: parent.teamId,
|
|
});
|
|
const share = await buildShare({
|
|
documentId: parent.id,
|
|
teamId: parent.teamId,
|
|
includeChildDocuments: true,
|
|
});
|
|
await ShareSubscription.create({
|
|
shareId: share.id,
|
|
documentId: parent.id,
|
|
email: "subscriber@example.com",
|
|
emailFingerprint: "subscriber@example.com",
|
|
secret: randomString(32),
|
|
confirmedAt: new Date(),
|
|
});
|
|
|
|
const task = new ShareSubscriptionNotificationsTask();
|
|
await task.perform({
|
|
name: "revisions.create",
|
|
documentId: sibling.id,
|
|
teamId: sibling.teamId,
|
|
actorId: sibling.createdById,
|
|
modelId: "revision-id",
|
|
ip,
|
|
});
|
|
|
|
expect(spy).not.toHaveBeenCalled();
|
|
});
|
|
});
|