Files
outline/server/utils/validators.test.ts
T
Tom Moor 5610df5a26 chore: Reduce no-explicit-any warnings in server directory (#12202)
* chore: Reduce no-explicit-any warnings in server directory

Tightens types across test response bodies, decorator signatures, the
TestServer wrapper, base class generics, and presenter Record types.
Where any is genuinely load-bearing (Sequelize model generics,
PropertyDescriptor decorator returns, plugin-registered template
classes, Fix mixin), keeps any with a targeted eslint-disable plus
reason rather than masking the constraint. Cuts server-only
no-explicit-any warnings from 162 to 70.

* fix: groups test asserts on first response instead of second

Caught by Copilot review on the no-explicit-any cleanup. Also fixes
the pre-existing getChangsetSkipped → getChangesetSkipped typo
surfaced while reviewing nearby decorator code.
2026-04-28 19:50:45 -04:00

321 lines
8.8 KiB
TypeScript

import { describe, it, expect } from "@jest/globals";
import { isDatabaseUrl, isMailboxAddress } from "./validators";
describe("isDatabaseUrl", () => {
const defaultOptions = {
protocols: ["postgres", "postgresql"],
require_tld: false,
allow_underscores: true,
};
describe("single host URLs", () => {
it("should accept a valid postgresql URL with single host", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@localhost:5432/database",
defaultOptions
)
).toBe(true);
});
it("should accept a valid postgres URL with single host", () => {
expect(
isDatabaseUrl(
"postgres://user:password@localhost:5432/database",
defaultOptions
)
).toBe(true);
});
it("should accept URL without port", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@localhost/database",
defaultOptions
)
).toBe(true);
});
it("should accept URL without database name", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@localhost:5432",
defaultOptions
)
).toBe(true);
});
it("should accept URL with query parameters", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@localhost:5432/database?sslmode=require",
defaultOptions
)
).toBe(true);
});
it("should accept URL with hostname containing underscores when allowed", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@my_host:5432/database",
defaultOptions
)
).toBe(true);
});
it("should accept URL with hostname containing hyphens", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@my-host:5432/database",
defaultOptions
)
).toBe(true);
});
});
describe("multi-host URLs", () => {
it("should accept multi-host URL with ports", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@node1.pg18:5432,node2.pg18:5432,node3.pg18:5432,node4.pg18:5432/database",
defaultOptions
)
).toBe(true);
});
it("should accept multi-host URL without ports", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@node1.pg18,node2.pg18,node3.pg18,node4.pg18/database",
defaultOptions
)
).toBe(true);
});
it("should accept multi-host URL with query parameters", () => {
expect(
isDatabaseUrl(
"postgresql://wiki_user:password@node1.pg18,node2.pg18,node3.pg18,node4.pg18/wiki?target_session_attrs=read-write",
defaultOptions
)
).toBe(true);
});
it("should accept multi-host URL with mixed port specifications", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@host1:5432,host2,host3:5433/database",
defaultOptions
)
).toBe(true);
});
it("should accept multi-host URL with two hosts", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@primary.db,replica.db/mydb",
defaultOptions
)
).toBe(true);
});
it("should accept multi-host URL without auth", () => {
expect(
isDatabaseUrl(
"postgresql://host1:5432,host2:5432/database",
defaultOptions
)
).toBe(true);
});
});
describe("invalid URLs", () => {
it("should reject empty string", () => {
expect(isDatabaseUrl("", defaultOptions)).toBe(false);
});
it("should reject null", () => {
expect(isDatabaseUrl(null as unknown as string, defaultOptions)).toBe(
false
);
});
it("should reject undefined", () => {
expect(
isDatabaseUrl(undefined as unknown as string, defaultOptions)
).toBe(false);
});
it("should reject URL with invalid protocol", () => {
expect(
isDatabaseUrl(
"mysql://user:password@localhost/database",
defaultOptions
)
).toBe(false);
});
it("should reject URL without protocol", () => {
expect(
isDatabaseUrl("user:password@localhost/database", defaultOptions)
).toBe(false);
});
it("should reject URL with empty host", () => {
expect(isDatabaseUrl("postgresql:///database", defaultOptions)).toBe(
false
);
});
it("should reject URL with invalid port", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@localhost:99999/database",
defaultOptions
)
).toBe(false);
});
it("should reject URL with invalid port (non-numeric)", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@localhost:abc/database",
defaultOptions
)
).toBe(false);
});
it("should reject multi-host URL with empty host", () => {
expect(
isDatabaseUrl(
"postgresql://user:password@host1,,host2/database",
defaultOptions
)
).toBe(false);
});
it("should reject URL with underscores when not allowed", () => {
expect(
isDatabaseUrl("postgresql://user:password@my_host:5432/database", {
...defaultOptions,
allow_underscores: false,
})
).toBe(false);
});
});
describe("protocol validation", () => {
it("should reject URL when protocol not in allowed list", () => {
expect(
isDatabaseUrl("postgresql://localhost/db", {
...defaultOptions,
protocols: ["postgres"],
})
).toBe(false);
});
it("should accept URL when protocol in custom allowed list", () => {
expect(
isDatabaseUrl("postgres://localhost/db", {
...defaultOptions,
protocols: ["postgres"],
})
).toBe(true);
});
});
describe("TLD requirement", () => {
it("should accept hostname with TLD when required", () => {
expect(
isDatabaseUrl("postgresql://user:password@host.example.com/database", {
...defaultOptions,
require_tld: true,
})
).toBe(true);
});
it("should reject hostname without TLD when required", () => {
expect(
isDatabaseUrl("postgresql://user:password@localhost/database", {
...defaultOptions,
require_tld: true,
})
).toBe(false);
});
it("should accept hostname without TLD when not required", () => {
expect(
isDatabaseUrl("postgresql://user:password@localhost/database", {
...defaultOptions,
require_tld: false,
})
).toBe(true);
});
});
});
describe("isMailboxAddress", () => {
describe("plain email addresses", () => {
it("should accept a plain email address", () => {
expect(isMailboxAddress("user@example.com")).toBe(true);
});
it("should accept an email with IP domain", () => {
expect(isMailboxAddress("user@192.168.1.1")).toBe(true);
});
it("should reject an invalid email address", () => {
expect(isMailboxAddress("notanemail")).toBe(false);
});
it("should reject an email without domain", () => {
expect(isMailboxAddress("user@")).toBe(false);
});
});
describe("mailbox format addresses", () => {
it("should accept a simple mailbox format", () => {
expect(isMailboxAddress("Outline <user@example.com>")).toBe(true);
});
it("should accept a mailbox format with a period in the display name", () => {
expect(isMailboxAddress("My App v1.0 <user@example.com>")).toBe(true);
});
it("should accept a mailbox format with quoted display name containing a comma", () => {
expect(isMailboxAddress('"Company, Inc." <user@example.com>')).toBe(true);
});
it("should accept a mailbox format with a quoted display name", () => {
expect(isMailboxAddress('"Outline" <user@example.com>')).toBe(true);
});
it("should reject a mailbox format with an unquoted comma in the display name", () => {
// addressparser splits on commas, so this creates two addresses
expect(isMailboxAddress("Company, Inc. <user@example.com>")).toBe(false);
});
it("should reject a mailbox format with an empty email address", () => {
expect(isMailboxAddress("Outline <>")).toBe(false);
});
it("should reject a mailbox format with an invalid email address", () => {
expect(isMailboxAddress("Outline <notanemail>")).toBe(false);
});
});
describe("edge cases", () => {
it("should reject an empty string", () => {
expect(isMailboxAddress("")).toBe(false);
});
it("should reject a string with only spaces", () => {
expect(isMailboxAddress(" ")).toBe(false);
});
it("should reject a group address", () => {
expect(isMailboxAddress("Group: user@example.com;")).toBe(false);
});
});
});