mirror of
https://github.com/outline/outline.git
synced 2026-06-13 03:14:59 +03:00
Tom Moor
ab3994f3f1
* feat: Toggle comments sidebar in editor lightbox Adds a new comments toggle button to the lightbox top-right actions. When toggled the sidebar slides out on the right and shows only the threads anchored to the active image node. A new comment form at the bottom creates a thread anchored to the image via a comment mark on the node. https://claude.ai/code/session_01W3duHkZJ6vgNPCQJL8hQK7 * fix: Make lightbox comments sidebar interactable The sidebar was being rendered as a sibling of Dialog.Content, so Radix's focus/click-outside trap blocked all interaction with it. Move it inside Dialog.Content so clicks and focus stay within the dialog. Also scope the lightbox handleKeyDown to only preventDefault and act on arrow/escape keys — and bail out entirely when typing into an input, textarea, or contenteditable so the comment form receives keystrokes. https://claude.ai/code/session_01W3duHkZJ6vgNPCQJL8hQK7 * fix: Align lightbox comments header with action buttons Nudge the sidebar Comments heading 4px down so its baseline lines up with the lightbox top-right action bar. https://claude.ai/code/session_01W3duHkZJ6vgNPCQJL8hQK7 * fix: Render lightbox sidebar popovers inside the dialog Reactions, menus, and tooltips inside the lightbox comments sidebar were portalling into the editor wrapper via PortalContext — which is hidden behind the lightbox overlay. Provide a PortalContext that targets the sidebar element itself so popovers render inside the dialog and remain visible. https://claude.ai/code/session_01W3duHkZJ6vgNPCQJL8hQK7 * fix: Prevent lightbox handlers from stealing focus from reply input Pointer events bubbling out of the comments sidebar were reaching the ancestor Dialog.Content / lightbox handlers and somehow disrupting focus on the ProseMirror reply input. Stop propagation of pointer, mouse, and click events at the CommentsSidebar so the sidebar owns its own interaction handling. https://claude.ai/code/session_01W3duHkZJ6vgNPCQJL8hQK7 * fix: Anchor lightbox close animation to current image position The close animation's translation was calculated relative to the image position cached when the image first loaded — before the comments sidebar could shift the image left. Recapture the natural position at the start of setupZoomOut so the animation correctly starts where the image actually is when the sidebar is open. https://claude.ai/code/session_01W3duHkZJ6vgNPCQJL8hQK7 * fix: Fade the comments sidebar with the rest of the lightbox The sidebar previously had only a slide-in animation on mount and stayed fully opaque while the rest of the lightbox faded out on close. Wire the sidebar to the shared fadeOut animation so it disappears in lockstep with the overlay and action controls. https://claude.ai/code/session_01W3duHkZJ6vgNPCQJL8hQK7 * Final fixes --------- Co-authored-by: Claude <noreply@anthropic.com>