mirror of
https://github.com/outline/outline.git
synced 2026-06-13 03:14:59 +03:00
b23a39bd39
* Add email verification check during sign-in flow * Add support for Entra External ID with OIDC standard verification claim
574 lines
18 KiB
TypeScript
574 lines
18 KiB
TypeScript
import { faker } from "@faker-js/faker";
|
|
import { randomUUID } from "node:crypto";
|
|
import { TeamDomain } from "@server/models";
|
|
import Collection from "@server/models/Collection";
|
|
import UserAuthentication from "@server/models/UserAuthentication";
|
|
import { buildUser, buildTeam, buildAdmin } from "@server/test/factories";
|
|
import { setSelfHosted } from "@server/test/support";
|
|
import accountProvisioner from "./accountProvisioner";
|
|
import { createContext } from "@server/context";
|
|
|
|
describe("accountProvisioner", () => {
|
|
const ip = faker.internet.ip();
|
|
const ctx = createContext({ ip });
|
|
|
|
describe("hosted", () => {
|
|
it("should create a new user and team", async () => {
|
|
const email = faker.internet.email();
|
|
const { user, team, isNewTeam, isNewUser } = await accountProvisioner(
|
|
ctx,
|
|
{
|
|
user: {
|
|
name: "Jenny Tester",
|
|
email,
|
|
avatarUrl: faker.image.avatar(),
|
|
},
|
|
team: {
|
|
name: "New workspace",
|
|
avatarUrl: faker.image.avatar(),
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: "google",
|
|
providerId: faker.internet.domainName(),
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
}
|
|
);
|
|
const authentications = await user.$get("authentications");
|
|
const auth = authentications[0];
|
|
expect(auth.accessToken).toEqual("123");
|
|
expect(auth.scopes.length).toEqual(1);
|
|
expect(auth.scopes[0]).toEqual("read");
|
|
expect(team.name).toEqual("New workspace");
|
|
expect(user.email).toEqual(email);
|
|
expect(isNewUser).toEqual(true);
|
|
expect(isNewTeam).toEqual(true);
|
|
const collectionCount = await Collection.count({
|
|
where: {
|
|
teamId: team.id,
|
|
},
|
|
});
|
|
expect(collectionCount).toEqual(1);
|
|
});
|
|
|
|
it("should update existing user and authentication", async () => {
|
|
const existingTeam = await buildTeam();
|
|
const providers = await existingTeam.$get("authenticationProviders");
|
|
const authenticationProvider = providers[0];
|
|
const existing = await buildUser({
|
|
teamId: existingTeam.id,
|
|
});
|
|
const authentications = await existing.$get("authentications");
|
|
const authentication = authentications[0];
|
|
const newEmail = faker.internet.email();
|
|
const { user, isNewUser, isNewTeam } = await accountProvisioner(ctx, {
|
|
user: {
|
|
name: existing.name,
|
|
email: newEmail,
|
|
avatarUrl: existing.avatarUrl,
|
|
},
|
|
team: {
|
|
name: existingTeam.name,
|
|
avatarUrl: existingTeam.avatarUrl,
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: authenticationProvider.name,
|
|
providerId: authenticationProvider.providerId,
|
|
},
|
|
authentication: {
|
|
providerId: authentication.providerId,
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
const auth = await UserAuthentication.findByPk(authentication.id);
|
|
expect(auth?.accessToken).toEqual("123");
|
|
expect(auth?.scopes.length).toEqual(1);
|
|
expect(auth?.scopes[0]).toEqual("read");
|
|
expect(user.email).toEqual(newEmail);
|
|
expect(isNewTeam).toEqual(false);
|
|
expect(isNewUser).toEqual(false);
|
|
});
|
|
|
|
it("should allow authentication by email matching", async () => {
|
|
const subdomain = faker.internet.domainWord();
|
|
const existingTeam = await buildTeam({
|
|
subdomain,
|
|
});
|
|
|
|
const providers = await existingTeam.$get("authenticationProviders");
|
|
const authenticationProvider = providers[0];
|
|
const email = faker.internet.email();
|
|
const userWithoutAuth = await buildUser({
|
|
email,
|
|
teamId: existingTeam.id,
|
|
authentications: [],
|
|
});
|
|
|
|
const { user, isNewUser, isNewTeam } = await accountProvisioner(ctx, {
|
|
user: {
|
|
name: userWithoutAuth.name,
|
|
email,
|
|
emailVerified: true,
|
|
avatarUrl: userWithoutAuth.avatarUrl,
|
|
},
|
|
team: {
|
|
teamId: existingTeam.id,
|
|
name: existingTeam.name,
|
|
avatarUrl: existingTeam.avatarUrl,
|
|
subdomain,
|
|
},
|
|
authenticationProvider: {
|
|
name: authenticationProvider.name,
|
|
providerId: authenticationProvider.providerId,
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
expect(user.id).toEqual(userWithoutAuth.id);
|
|
expect(isNewTeam).toEqual(false);
|
|
expect(isNewUser).toEqual(false);
|
|
});
|
|
|
|
it("should not allow authentication by email matching when email is unverified", async () => {
|
|
const subdomain = faker.internet.domainWord();
|
|
const existingTeam = await buildTeam({
|
|
subdomain,
|
|
});
|
|
|
|
const providers = await existingTeam.$get("authenticationProviders");
|
|
const authenticationProvider = providers[0];
|
|
const email = faker.internet.email();
|
|
const userWithoutAuth = await buildUser({
|
|
email,
|
|
teamId: existingTeam.id,
|
|
authentications: [],
|
|
});
|
|
|
|
let error;
|
|
try {
|
|
await accountProvisioner(ctx, {
|
|
user: {
|
|
name: userWithoutAuth.name,
|
|
email,
|
|
emailVerified: false,
|
|
avatarUrl: userWithoutAuth.avatarUrl,
|
|
},
|
|
team: {
|
|
teamId: existingTeam.id,
|
|
name: existingTeam.name,
|
|
avatarUrl: existingTeam.avatarUrl,
|
|
subdomain,
|
|
},
|
|
authenticationProvider: {
|
|
name: authenticationProvider.name,
|
|
providerId: authenticationProvider.providerId,
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
} catch (err) {
|
|
error = err;
|
|
}
|
|
|
|
expect(error).toBeTruthy();
|
|
expect(error.id).toEqual("invalid_authentication");
|
|
});
|
|
|
|
it("should throw an error when authentication provider is disabled", async () => {
|
|
const existingTeam = await buildTeam();
|
|
const providers = await existingTeam.$get("authenticationProviders");
|
|
const authenticationProvider = providers[0];
|
|
await authenticationProvider.update({
|
|
enabled: false,
|
|
});
|
|
const existing = await buildUser({
|
|
teamId: existingTeam.id,
|
|
});
|
|
const authentications = await existing.$get("authentications");
|
|
const authentication = authentications[0];
|
|
let error;
|
|
|
|
try {
|
|
await accountProvisioner(ctx, {
|
|
user: {
|
|
name: existing.name,
|
|
email: existing.email!,
|
|
avatarUrl: existing.avatarUrl,
|
|
},
|
|
team: {
|
|
name: existingTeam.name,
|
|
avatarUrl: existingTeam.avatarUrl,
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: authenticationProvider.name,
|
|
providerId: authenticationProvider.providerId,
|
|
},
|
|
authentication: {
|
|
providerId: authentication.providerId,
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
} catch (err) {
|
|
error = err;
|
|
}
|
|
|
|
expect(error).toBeTruthy();
|
|
});
|
|
|
|
it("should prioritize enabled authentication provider", async () => {
|
|
const existingTeam = await buildTeam();
|
|
const existingProviders = await existingTeam.$get(
|
|
"authenticationProviders"
|
|
);
|
|
|
|
const team2 = await buildTeam();
|
|
|
|
const providers = await team2.$get("authenticationProviders");
|
|
const authenticationProvider = providers[0];
|
|
await authenticationProvider.update({
|
|
enabled: false,
|
|
providerId: existingProviders[0].providerId,
|
|
});
|
|
|
|
const existing = await buildUser({
|
|
teamId: existingTeam.id,
|
|
});
|
|
const authentications = await existing.$get("authentications");
|
|
const authentication = authentications[0];
|
|
const { isNewUser, isNewTeam } = await accountProvisioner(ctx, {
|
|
user: {
|
|
name: existing.name,
|
|
email: existing.email!,
|
|
avatarUrl: existing.avatarUrl,
|
|
},
|
|
team: {
|
|
name: existingTeam.name,
|
|
avatarUrl: existingTeam.avatarUrl,
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: authenticationProvider.name,
|
|
providerId: authenticationProvider.providerId,
|
|
},
|
|
authentication: {
|
|
providerId: authentication.providerId,
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
const auth = await UserAuthentication.findByPk(authentication.id);
|
|
expect(auth?.accessToken).toEqual("123");
|
|
expect(auth?.scopes.length).toEqual(1);
|
|
expect(auth?.scopes[0]).toEqual("read");
|
|
expect(isNewTeam).toEqual(false);
|
|
expect(isNewUser).toEqual(false);
|
|
});
|
|
|
|
it("should throw an error when the domain is not allowed", async () => {
|
|
const existingTeam = await buildTeam();
|
|
const admin = await buildAdmin({ teamId: existingTeam.id });
|
|
const providers = await existingTeam.$get("authenticationProviders");
|
|
const authenticationProvider = providers[0];
|
|
const email = faker.internet.email();
|
|
|
|
await TeamDomain.create({
|
|
teamId: existingTeam.id,
|
|
name: "other.com",
|
|
createdById: admin.id,
|
|
});
|
|
|
|
let error;
|
|
|
|
try {
|
|
await accountProvisioner(ctx, {
|
|
user: {
|
|
name: "Jenny Tester",
|
|
email,
|
|
emailVerified: true,
|
|
avatarUrl: faker.image.avatar(),
|
|
},
|
|
team: {
|
|
avatarUrl: existingTeam.avatarUrl,
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: authenticationProvider.name,
|
|
providerId: authenticationProvider.providerId,
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
} catch (err) {
|
|
error = err;
|
|
}
|
|
|
|
expect(error).toBeTruthy();
|
|
});
|
|
|
|
it("should create a new user in an existing team when the domain is allowed", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({ teamId: team.id });
|
|
const authenticationProviders = await team.$get(
|
|
"authenticationProviders"
|
|
);
|
|
const authenticationProvider = authenticationProviders[0];
|
|
const domain = faker.internet.domainName();
|
|
await TeamDomain.create({
|
|
teamId: team.id,
|
|
name: domain,
|
|
createdById: admin.id,
|
|
});
|
|
const email = faker.internet.email({ provider: domain });
|
|
const { user, isNewUser } = await accountProvisioner(ctx, {
|
|
user: {
|
|
name: "Jenny Tester",
|
|
email,
|
|
emailVerified: true,
|
|
avatarUrl: faker.image.avatar(),
|
|
},
|
|
team: {
|
|
avatarUrl: team.avatarUrl,
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: authenticationProvider.name,
|
|
providerId: authenticationProvider.providerId,
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
const authentications = await user.$get("authentications");
|
|
const auth = authentications[0];
|
|
expect(auth.accessToken).toEqual("123");
|
|
expect(auth.scopes.length).toEqual(1);
|
|
expect(auth.scopes[0]).toEqual("read");
|
|
expect(user.email).toEqual(email);
|
|
expect(isNewUser).toEqual(true);
|
|
// should provision welcome collection
|
|
const collectionCount = await Collection.count({
|
|
where: {
|
|
teamId: team.id,
|
|
},
|
|
});
|
|
expect(collectionCount).toEqual(1);
|
|
});
|
|
|
|
it("should create a new user in an existing team", async () => {
|
|
const team = await buildTeam();
|
|
const authenticationProviders = await team.$get(
|
|
"authenticationProviders"
|
|
);
|
|
const authenticationProvider = authenticationProviders[0];
|
|
const email = faker.internet.email();
|
|
const { user, isNewUser } = await accountProvisioner(ctx, {
|
|
user: {
|
|
name: "Jenny Tester",
|
|
email,
|
|
avatarUrl: faker.image.avatar(),
|
|
},
|
|
team: {
|
|
name: team.name,
|
|
avatarUrl: team.avatarUrl,
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: authenticationProvider.name,
|
|
providerId: authenticationProvider.providerId,
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
const authentications = await user.$get("authentications");
|
|
const auth = authentications[0];
|
|
expect(auth.accessToken).toEqual("123");
|
|
expect(auth.scopes.length).toEqual(1);
|
|
expect(auth.scopes[0]).toEqual("read");
|
|
expect(user.email).toEqual(email);
|
|
expect(isNewUser).toEqual(true);
|
|
// should provision welcome collection
|
|
const collectionCount = await Collection.count({
|
|
where: {
|
|
teamId: team.id,
|
|
},
|
|
});
|
|
expect(collectionCount).toEqual(1);
|
|
});
|
|
|
|
it("should handle emails with capital letters correctly", async () => {
|
|
const email = "Jenny.Tester@EXAMPLE.COM";
|
|
|
|
const params = {
|
|
user: {
|
|
name: "Jenny Tester",
|
|
email,
|
|
avatarUrl: faker.image.avatar(),
|
|
},
|
|
team: {
|
|
name: "New workspace",
|
|
avatarUrl: faker.image.avatar(),
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: "google",
|
|
providerId: faker.internet.domainName(),
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
};
|
|
|
|
const { user, isNewTeam, isNewUser } = await accountProvisioner(
|
|
ctx,
|
|
params
|
|
);
|
|
|
|
expect(user.email).toEqual(email);
|
|
expect(isNewUser).toEqual(true);
|
|
expect(isNewTeam).toEqual(true);
|
|
|
|
// Test that we can find the user again
|
|
const existing = await accountProvisioner(ctx, params);
|
|
|
|
expect(user.email).toEqual(email);
|
|
expect(existing.isNewTeam).toEqual(false);
|
|
expect(existing.isNewUser).toEqual(false);
|
|
expect(existing.user.id).toEqual(user.id);
|
|
});
|
|
|
|
it("should allow connecting a new authentication provider while logged in", async () => {
|
|
const admin = await buildAdmin();
|
|
const team = admin.team;
|
|
const ctxWithAdmin = createContext({ ip, user: admin });
|
|
|
|
const providerId = faker.internet.domainName();
|
|
const { user, isNewTeam, isNewUser } = await accountProvisioner(
|
|
ctxWithAdmin,
|
|
{
|
|
user: {
|
|
name: admin.name,
|
|
email: admin.email!,
|
|
},
|
|
team: {
|
|
teamId: team.id,
|
|
subdomain: team.subdomain!,
|
|
},
|
|
authenticationProvider: {
|
|
name: "google",
|
|
providerId,
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "456",
|
|
scopes: ["read"],
|
|
},
|
|
}
|
|
);
|
|
|
|
expect(user.id).toEqual(admin.id);
|
|
expect(isNewUser).toEqual(false);
|
|
expect(isNewTeam).toEqual(false);
|
|
|
|
const providers = await team.$get("authenticationProviders");
|
|
expect(providers.find((p) => p.name === "google")).toBeTruthy();
|
|
});
|
|
});
|
|
|
|
describe("self hosted", () => {
|
|
beforeEach(setSelfHosted);
|
|
|
|
it("should fail if existing team and domain not in allowed list", async () => {
|
|
let error;
|
|
const team = await buildTeam();
|
|
|
|
try {
|
|
await accountProvisioner(ctx, {
|
|
user: {
|
|
name: "Jenny Tester",
|
|
email: faker.internet.email(),
|
|
avatarUrl: faker.image.avatar(),
|
|
},
|
|
team: {
|
|
teamId: team.id,
|
|
name: team.name,
|
|
avatarUrl: team.avatarUrl,
|
|
subdomain: faker.internet.domainWord(),
|
|
},
|
|
authenticationProvider: {
|
|
name: "google",
|
|
providerId: faker.internet.domainName(),
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
} catch (err) {
|
|
error = err;
|
|
}
|
|
|
|
expect(error.message).toEqual("Invalid authentication");
|
|
});
|
|
|
|
it("should always use existing team if self-hosted", async () => {
|
|
const team = await buildTeam();
|
|
const domain = faker.internet.domainName();
|
|
const { user, isNewUser } = await accountProvisioner(ctx, {
|
|
user: {
|
|
name: "Jenny Tester",
|
|
email: faker.internet.email(),
|
|
avatarUrl: faker.image.avatar(),
|
|
},
|
|
team: {
|
|
teamId: team.id,
|
|
name: team.name,
|
|
avatarUrl: team.avatarUrl,
|
|
subdomain: faker.internet.domainWord(),
|
|
domain,
|
|
},
|
|
authenticationProvider: {
|
|
name: "google",
|
|
providerId: domain,
|
|
},
|
|
authentication: {
|
|
providerId: randomUUID(),
|
|
accessToken: "123",
|
|
scopes: ["read"],
|
|
},
|
|
});
|
|
|
|
expect(user.teamId).toEqual(team.id);
|
|
expect(isNewUser).toEqual(true);
|
|
|
|
const providers = await team.$get("authenticationProviders");
|
|
expect(providers.length).toEqual(2);
|
|
});
|
|
});
|
|
});
|