Files
outline/server/queues/tasks/UpdateDocumentsPopularityScoreTask.ts
T
Tom Moor b51692cdc5 feat: Add popularity scoring (#10721)
* Simple first pass

* Use findAllInBatches

* Add comments,views,revisions

* Add 'popular' tab to Home

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Add 'Popular' tab to collections

* Boost search results based on popularityScore

* Move to unlogged temp table

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-25 13:11:05 +01:00

371 lines
11 KiB
TypeScript

import crypto from "crypto";
import { subWeeks } from "date-fns";
import { QueryTypes } from "sequelize";
import Logger from "@server/logging/Logger";
import BaseTask, { TaskSchedule } from "./BaseTask";
import { sequelize } from "@server/storage/database";
type Props = Record<string, never>;
/**
* Gravity constant for time decay. Higher values cause faster decay of older content.
* With `GRAVITY = 0.7`:
* - Content from **1 day ago** retains ~30% of its score
* - Content from **3 days ago** retains ~15% of its score
* - Content from **1 week ago** retains ~8% of its score
* - Content from **2 weeks ago** retains ~4% of its score
*/
const GRAVITY = 0.7;
/**
* Number of hours to add to age to smooth the decay curve,
* preventing brand new content from having disproportionately
* high scores compared to content just a few hours old.
*/
const TIME_OFFSET_HOURS = 2;
/**
* Weight multipliers for different activity types relative to base score
*/
const ACTIVITY_WEIGHTS = {
revision: 1.0,
comment: 1.2,
view: 0.5,
};
/**
* Only recalculate scores for activity within this period.
*/
const ACTIVITY_THRESHOLD_WEEKS = 2;
/**
* Batch size for processing updates - each batch is an independent transaction
*/
const BATCH_SIZE = 500;
/**
* Maximum retries for failed batch operations
*/
const MAX_RETRIES = 3;
/**
* Delay between retries in milliseconds
*/
const RETRY_DELAY_MS = 1000;
/**
* Base name for the working table used to track documents to process
*/
const WORKING_TABLE_PREFIX = "popularity_score_working";
export default class UpdateDocumentsPopularityScoreTask extends BaseTask<Props> {
/**
* Unique table name for this task run to prevent conflicts with concurrent runs
*/
private workingTable: string = "";
static cron = TaskSchedule.Day;
public async perform() {
Logger.info("task", "Updating document popularity scores…");
const now = new Date();
const activityThreshold = subWeeks(now, ACTIVITY_THRESHOLD_WEEKS);
// Generate unique table name for this run to prevent conflicts
const uniqueId = crypto.randomBytes(8).toString("hex");
this.workingTable = `${WORKING_TABLE_PREFIX}_${uniqueId}`;
try {
// Setup: Create working table and populate with active document IDs
await this.setupWorkingTable(activityThreshold);
const activeCount = await this.getWorkingTableCount();
if (activeCount === 0) {
Logger.info("task", "No documents with recent activity found");
return;
}
Logger.info(
"task",
`Found ${activeCount} documents with recent activity`
);
// Process documents in independent batches
let totalUpdated = 0;
let totalErrors = 0;
let batchNumber = 0;
while (true) {
const remaining = await this.getWorkingTableCount();
if (remaining === 0) {
break;
}
batchNumber++;
try {
const updated = await this.processBatchWithRetry(
activityThreshold,
now
);
totalUpdated += updated;
Logger.debug(
"task",
`Batch ${batchNumber}: updated ${updated} documents, ${remaining - updated} remaining`
);
} catch (error) {
totalErrors++;
Logger.error(`Batch ${batchNumber} failed after retries`, error);
// Remove failed batch from working table to prevent infinite loop
await this.skipCurrentBatch();
}
}
Logger.info(
"task",
`Completed updating popularity scores: ${totalUpdated} documents updated, ${totalErrors} batch errors`
);
} catch (error) {
Logger.error("Failed to update document popularity scores", error);
throw error;
} finally {
// Always clean up the working table
await this.cleanupWorkingTable();
}
}
/**
* Creates an unlogged working table and populates it with document IDs
* that have recent activity. Unlogged tables are faster because they
* skip WAL logging, and data loss on crash is acceptable here.
*/
private async setupWorkingTable(activityThreshold: Date): Promise<void> {
// Drop any existing table first to avoid type conflicts from previous crashed runs
await sequelize.query(`DROP TABLE IF EXISTS ${this.workingTable} CASCADE`);
// Create unlogged table - faster than regular tables as it skips WAL logging
await sequelize.query(`
CREATE UNLOGGED TABLE ${this.workingTable} (
"documentId" UUID PRIMARY KEY,
processed BOOLEAN DEFAULT FALSE
)
`);
// Populate with documents that have recent activity and are valid
// (published, not deleted). Using JOINs to filter upfront.
await sequelize.query(
`
INSERT INTO ${this.workingTable} ("documentId")
SELECT DISTINCT d.id
FROM documents d
WHERE d."publishedAt" IS NOT NULL
AND d."deletedAt" IS NULL
AND (
EXISTS (
SELECT 1 FROM revisions r
WHERE r."documentId" = d.id AND r."createdAt" >= :threshold
)
OR EXISTS (
SELECT 1 FROM comments c
WHERE c."documentId" = d.id AND c."createdAt" >= :threshold
)
OR EXISTS (
SELECT 1 FROM views v
WHERE v."documentId" = d.id AND v."updatedAt" >= :threshold
)
)
`,
{ replacements: { threshold: activityThreshold } }
);
// Create index on processed column for efficient batch selection
await sequelize.query(`
CREATE INDEX ON ${this.workingTable} (processed) WHERE NOT processed
`);
}
/**
* Returns count of unprocessed documents in working table
*/
private async getWorkingTableCount(): Promise<number> {
const [result] = await sequelize.query<{ count: string }>(
`SELECT COUNT(*) as count FROM ${this.workingTable} WHERE NOT processed`,
{ type: QueryTypes.SELECT }
);
return parseInt(result.count, 10);
}
/**
* Processes a batch of documents with retry logic.
* Each batch is an independent transaction that commits on success.
*/
private async processBatchWithRetry(
activityThreshold: Date,
now: Date,
attempt = 1
): Promise<number> {
try {
return await sequelize.transaction(async (transaction) => {
// Select and lock a batch of unprocessed documents
const batch = await sequelize.query<{ documentId: string }>(
`
SELECT "documentId" FROM ${this.workingTable}
WHERE NOT processed
ORDER BY "documentId"
LIMIT :limit
FOR UPDATE SKIP LOCKED
`,
{
replacements: { limit: BATCH_SIZE },
type: QueryTypes.SELECT,
transaction,
}
);
if (batch.length === 0) {
return 0;
}
const documentIds = batch.map((b) => b.documentId);
// Build VALUES clause for the batch, sequelize did not like array parameters in casted in clause.
const valuesClause = documentIds
.map((id) => `('${id}'::uuid)`)
.join(", ");
// Calculate and update scores using JOINs (no IN clause with large arrays)
await sequelize.query(
`
WITH batch_docs AS (
SELECT * FROM (VALUES ${valuesClause}) AS t(id)
),
revision_scores AS (
SELECT
r."documentId",
SUM(:revisionWeight / POWER(
GREATEST(EXTRACT(EPOCH FROM (:now::timestamp - r."createdAt")) / 3600 + :timeOffset, 0.1),
:gravity
)) as score
FROM revisions r
INNER JOIN batch_docs bd ON r."documentId" = bd.id
WHERE r."createdAt" >= :threshold
GROUP BY r."documentId"
),
comment_scores AS (
SELECT
c."documentId",
SUM(:commentWeight / POWER(
GREATEST(EXTRACT(EPOCH FROM (:now::timestamp - c."createdAt")) / 3600 + :timeOffset, 0.1),
:gravity
)) as score
FROM comments c
INNER JOIN batch_docs bd ON c."documentId" = bd.id
WHERE c."createdAt" >= :threshold
GROUP BY c."documentId"
),
view_scores AS (
SELECT
v."documentId",
SUM(:viewWeight / POWER(
GREATEST(EXTRACT(EPOCH FROM (:now::timestamp - v."updatedAt")) / 3600 + :timeOffset, 0.1),
:gravity
)) as score
FROM views v
INNER JOIN batch_docs bd ON v."documentId" = bd.id
WHERE v."updatedAt" >= :threshold
GROUP BY v."documentId"
),
combined_scores AS (
SELECT
bd.id as "documentId",
COALESCE(rs.score, 0) + COALESCE(cs.score, 0) + COALESCE(vs.score, 0) as total_score
FROM batch_docs bd
LEFT JOIN revision_scores rs ON bd.id = rs."documentId"
LEFT JOIN comment_scores cs ON bd.id = cs."documentId"
LEFT JOIN view_scores vs ON bd.id = vs."documentId"
)
UPDATE documents
SET "popularityScore" = combined_scores.total_score
FROM combined_scores
WHERE documents.id = combined_scores."documentId"
`,
{
replacements: {
threshold: activityThreshold,
now,
gravity: GRAVITY,
timeOffset: TIME_OFFSET_HOURS,
revisionWeight: ACTIVITY_WEIGHTS.revision,
commentWeight: ACTIVITY_WEIGHTS.comment,
viewWeight: ACTIVITY_WEIGHTS.view,
},
transaction,
}
);
// Mark batch as processed
await sequelize.query(
`
UPDATE ${this.workingTable}
SET processed = TRUE
WHERE "documentId" IN (SELECT id FROM (VALUES ${valuesClause}) AS t(id))
`,
{ transaction }
);
return documentIds.length;
});
} catch (error) {
if (attempt < MAX_RETRIES) {
Logger.warn(
`Batch update failed, retrying (attempt ${attempt + 1}/${MAX_RETRIES})`,
{ error }
);
await this.sleep(RETRY_DELAY_MS * attempt);
return this.processBatchWithRetry(activityThreshold, now, attempt + 1);
}
throw error;
}
}
/**
* Marks current batch as processed without updating scores.
* Used when a batch fails repeatedly to prevent infinite loops.
*/
private async skipCurrentBatch(): Promise<void> {
await sequelize.query(
`
UPDATE ${this.workingTable}
SET processed = TRUE
WHERE "documentId" IN (
SELECT "documentId" FROM ${this.workingTable}
WHERE NOT processed
ORDER BY "documentId"
LIMIT :limit
)
`,
{ replacements: { limit: BATCH_SIZE } }
);
}
/**
* Removes the working table
*/
private async cleanupWorkingTable(): Promise<void> {
try {
await sequelize.query(
`DROP TABLE IF EXISTS ${this.workingTable} CASCADE`
);
} catch (error) {
Logger.warn("Failed to clean up working table", { error });
}
}
private sleep(ms: number): Promise<void> {
return new Promise((resolve) => setTimeout(resolve, ms));
}
}