Files
outline/server/utils/fetch.ts
T
Tom Moor 0139b91b5d chore: Replace lodash with es-toolkit (#12281)
* chore: Replace lodash with es-toolkit

Migrate all direct lodash imports to es-toolkit/compat for a smaller,
faster, lodash-compatible utility library. Transitive lodash usage from
other packages remains unchanged.

* fix: Restore isPlainObject semantics in CanCan policy

The lodash migration aliased `isObject` to `lodash/isPlainObject` and
the codemod incorrectly mapped the local name to es-toolkit's `isObject`,
which also returns true for arrays and functions. This caused condition
objects in policy definitions to be skipped, breaking authorization
checks across the codebase.

* fix: Restore unicode-aware length counting in validators

es-toolkit/compat's size() returns string.length, while lodash's _.size()
counts unicode code points. Switch to [...value].length to preserve the
previous behavior so multi-byte characters like emoji count as one.
2026-05-06 21:03:47 -04:00

325 lines
9.9 KiB
TypeScript

/* oxlint-disable no-restricted-imports, react/rules-of-hooks */
import { promises as dns } from "node:dns";
import type http from "node:http";
import type https from "node:https";
import * as net from "node:net";
import nodeFetch, {
Headers,
type RequestInit,
type Response,
} from "node-fetch";
import { getProxyForUrl } from "proxy-from-env";
import tunnelAgent, { type TunnelAgent } from "tunnel-agent";
import env from "@server/env";
import { InternalError } from "@server/errors";
import Logger from "@server/logging/Logger";
import { capitalize } from "es-toolkit/compat";
import {
type RequestFilteringAgentOptions,
useAgent as useFilteringAgent,
validateIPAddress,
} from "./requestFilteringAgent";
interface UrlWithTunnel extends URL {
tunnelMethod?: string;
}
const DefaultOptions = {
keepAlive: true,
timeout: 1000,
keepAliveMsecs: 500,
maxSockets: 200,
maxFreeSockets: 5,
maxCachedSessions: 500,
};
export type { RequestInit } from "node-fetch";
export { Headers };
/**
* Default user agent string for outgoing requests.
*/
export const outlineUserAgent = `Outline-${
env.VERSION ? `/${env.VERSION.slice(0, 7)}` : ""
}`;
/**
* Fake Chrome user agent string for use in fetch requests to
* improve reliability.
*/
export const chromeUserAgent =
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36";
/**
* Resolves the URL's hostname and validates every returned address against the
* filtering rules. Used as a pre-flight check when a proxy is configured,
* since both proxy code paths in buildAgent() bypass the per-connection DNS
* hook in the filtering agent.
*
* @param url The target URL to validate.
* @param options Allow/deny rules to apply.
* @param signal Optional abort signal — if it fires (e.g. fetch timeout),
* the validation rejects with an AbortError so the configured timeout
* applies to slow DNS resolution as well.
* @throws An error if any resolved address is disallowed.
*/
const validateTargetURL = async (
url: URL,
options: RequestFilteringAgentOptions,
signal?: AbortSignal | null
): Promise<void> => {
const host = url.hostname;
const lookup =
net.isIP(host) !== 0
? Promise.resolve([{ address: host, family: net.isIP(host) }])
: dns.lookup(host, { all: true });
const addresses = signal
? await Promise.race([
lookup,
new Promise<never>((_, reject) => {
if (signal.aborted) {
reject(Object.assign(new Error("aborted"), { name: "AbortError" }));
return;
}
signal.addEventListener(
"abort",
() =>
reject(
Object.assign(new Error("aborted"), { name: "AbortError" })
),
{ once: true }
);
}),
])
: await lookup;
for (const { address, family } of addresses) {
const err = validateIPAddress({ address, family, host }, options);
if (err) {
throw err;
}
}
};
/**
* Wrapper around fetch that uses the request-filtering-agent in cloud hosted
* environments to filter malicious requests, and the fetch-with-proxy library
* in self-hosted environments to allow for request from behind a proxy.
*
* @param url The url to fetch
* @param init The fetch init object
* @returns The response
*/
export default async function fetch(
url: string,
init?: RequestInit & {
allowPrivateIPAddress?: boolean;
timeout?: number;
}
): Promise<Response> {
Logger.silly("http", `Network request to ${url}`, init);
const { allowPrivateIPAddress, timeout, ...rest } = init || {};
// Create AbortController for timeout if specified
let abortController: AbortController | undefined;
let timeoutId: NodeJS.Timeout | undefined;
if (timeout && !rest.signal) {
abortController = new AbortController();
timeoutId = setTimeout(() => {
abortController?.abort();
}, timeout);
}
const signal = abortController?.signal || rest.signal;
try {
// When a proxy is configured, the request-filtering-agent's per-connection
// DNS hook does not see the target host (the tunnel-agent path bypasses it
// entirely, and the http-over-http path only filters the proxy's IP).
// Pre-resolve and validate the target ourselves so SSRF protection still
// applies to user-supplied URLs.
//
// We resolve DNS locally, but the proxy performs its own DNS resolution
// when forwarding the request. A determined attacker controlling DNS
// could return a public IP here and a private IP to the proxy. Closing
// that gap would require the proxy itself to enforce egress rules.
const parsedURL = new URL(url);
if (getProxyForUrl(parsedURL.href)) {
await validateTargetURL(
parsedURL,
{
allowPrivateIPAddress,
allowIPAddressList: env.ALLOWED_PRIVATE_IP_ADDRESSES ?? [],
},
signal
);
}
const response = await nodeFetch(url, {
...rest,
headers: {
"User-Agent": outlineUserAgent,
...rest?.headers,
},
signal,
agent: buildAgent(url, { signal, allowPrivateIPAddress }),
});
if (!response.ok) {
Logger.silly("http", `Network request failed`, {
url,
status: response.status,
statusText: response.statusText,
headers: response.headers.raw(),
});
}
return response;
} catch (err) {
if (err.name === "AbortError") {
throw new Error(`Request timeout after ${timeout}ms`);
}
if (!env.isCloudHosted && err.message?.startsWith("DNS lookup")) {
throw InternalError(
`${err.message}\n\nTo allow this request, add the IP address or CIDR range to the ALLOWED_PRIVATE_IP_ADDRESSES environment variable.`
);
}
throw err;
} finally {
if (timeoutId) {
clearTimeout(timeoutId);
}
}
}
/**
* Parses the proxy URL and returns an object with the properties
*
* @param url The URL to be fetched
* @param proxyURL The proxy URL to be used
* @returns An object containing the parsed proxy URL and tunnel method
*/
const parseProxy = (url: URL, proxyURL: string) => {
const proxyObject = new URL(proxyURL) as UrlWithTunnel;
const proxyProtocol = proxyObject.protocol?.replace(":", "");
const proxyPort =
proxyObject.port || (proxyProtocol === "https" ? "443" : "80");
proxyObject.port = proxyPort;
proxyObject.tunnelMethod = url.protocol
?.replace(":", "")
.concat("Over")
.concat(capitalize(proxyProtocol));
return proxyObject;
};
/**
* Builds a tunnel agent for the given proxy URL and options. Note that tunnel
* agents do not perform request filtering.
*
* @param proxy The parsed proxy URL
* @param options The request options
* @returns A tunnel agent for the proxy
*/
const buildTunnel = (proxy: UrlWithTunnel, options: RequestInit) => {
if (!proxy.tunnelMethod) {
Logger.warn("Proxy tunnel method not defined");
return;
}
if (!(proxy.tunnelMethod in tunnelAgent)) {
Logger.warn(`Proxy tunnel method not supported: ${proxy.tunnelMethod}`);
return;
}
const proxyAuth =
proxy.username || proxy.password
? `${proxy.username}:${proxy.password}`
: undefined;
return tunnelAgent[proxy.tunnelMethod as keyof TunnelAgent]({
...options,
proxy: {
port: proxy.port,
host: proxy.hostname,
proxyAuth,
},
});
};
/**
* Creates a http or https agent for the given URL, applying request filtering
* if necessary. If a proxy is detected in the environment, it will use that
* proxy agent to tunnel the request.
*
* @param url The URL to fetch.
* @param options Options controlling agent behavior.
* @param options.signal An abort signal used to destroy the agent on cancellation or timeout.
* @param options.allowPrivateIPAddress Whether to allow requests to private IP addresses.
* @returns An http or https agent configured for the URL.
*/
function buildAgent(
url: string,
options: {
signal?: AbortSignal | null;
allowPrivateIPAddress?: boolean;
} = {}
) {
const agentOptions = { ...DefaultOptions };
const parsedURL = new URL(url);
const proxyURL = getProxyForUrl(parsedURL.href);
let agent: https.Agent | http.Agent | undefined;
// Add allowIPAddressList from environment configuration
const filteringOptions = {
...agentOptions,
allowPrivateIPAddress: options.allowPrivateIPAddress,
allowIPAddressList: env.ALLOWED_PRIVATE_IP_ADDRESSES ?? [],
};
if (proxyURL) {
const parsedProxyURL = parseProxy(parsedURL, proxyURL);
Logger.silly("http", `Using proxy for request`, {
url: parsedURL.toString(),
proxy: parsedProxyURL.href,
tunnelMethod: parsedProxyURL.tunnelMethod,
username: parsedProxyURL.username || undefined,
password: parsedProxyURL.password ? "******" : undefined,
});
if (parsedProxyURL.tunnelMethod?.startsWith("httpOver")) {
const proxyURL = new URL(parsedProxyURL.href);
proxyURL.pathname = (parsedURL.protocol ?? "")
.concat("//")
.concat(parsedURL.host ?? "")
.concat(parsedURL.pathname + parsedURL.search);
if (parsedProxyURL.username || parsedProxyURL.password) {
proxyURL.username = parsedProxyURL.username;
proxyURL.password = parsedProxyURL.password;
}
agent = useFilteringAgent(proxyURL.toString(), filteringOptions);
} else {
// tunnel-agent bypasses the filtering agent's per-connection DNS hook,
// so SSRF protection for this branch comes from the validateTargetURL
// pre-flight in fetch() above.
agent =
buildTunnel(parsedProxyURL, agentOptions) ||
useFilteringAgent(parsedURL.toString(), filteringOptions);
}
} else {
agent = useFilteringAgent(parsedURL.toString(), filteringOptions);
}
if (options.signal) {
options.signal.addEventListener("abort", () => {
if (agent && "destroy" in agent) {
agent.destroy();
}
});
}
return agent;
}