GitHub/tiddl
1
0
Fork 0
mirror of https://github.com/oskvr37/tiddl.git synced 2026-06-13 04:05:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

♻️ Skipping errors is now a default behaviour

Browse Source
This commit is contained in:
Oskar Dudziński
2026-04-09 20:57:04 +02:00
committed by GitHub
parent a1deba92cc
commit 89e4d5c08e
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tiddl/cli/commands/download/__init__.py
+16 -16
View File
@@ -118,12 +118,12 @@ def download_callback(
help="Videos handling: 'none' to exclude, 'allow' to include, 'only' to download videos only.", help="Videos handling: 'none' to exclude, 'allow' to include, 'only' to download videos only.",
), ),
] = CONFIG.download.videos_filter, ] = CONFIG.download.videos_filter,
SKIP_ERRORS: Annotated[ RAISE_ERRORS: Annotated[
bool, bool,
typer.Option( typer.Option(
"--skip-errors", "--raise-errors",
"-se", "-err",
help="Skip unavailable items and continue downloading the rest.", help="Raise an error on resource download failure. Use for debugging",
), ),
] = False, ] = False,
): ):
@@ -343,13 +343,13 @@ def download_callback(
if hasattr(item, 'album') and item.album: if hasattr(item, 'album') and item.album:
track_info += f", Album ID: {item.album.id}" track_info += f", Album ID: {item.album.id}"
ctx.obj.console.print(f"[red]API Error:[/] {e} ({track_info})") ctx.obj.console.print(f"[red]API Error:[/] {e} ({track_info})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
except Exception as e: except Exception as e:
item = album_item.item item = album_item.item
track_info = f"Track: {getattr(item, 'title', 'Unknown')} (ID: {item.id})" track_info = f"Track: {getattr(item, 'title', 'Unknown')} (ID: {item.id})"
ctx.obj.console.print(f"[red]Error:[/] {e} ({track_info})") ctx.obj.console.print(f"[red]Error:[/] {e} ({track_info})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
offset += album_items.limit offset += album_items.limit
@@ -463,13 +463,13 @@ def download_callback(
item = mix_item.item item = mix_item.item
track_info = f"Track: {getattr(item, 'title', 'Unknown')} (ID: {item.id})" track_info = f"Track: {getattr(item, 'title', 'Unknown')} (ID: {item.id})"
ctx.obj.console.print(f"[red]API Error:[/] {e} ({track_info})") ctx.obj.console.print(f"[red]API Error:[/] {e} ({track_info})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
except Exception as e: except Exception as e:
item = mix_item.item item = mix_item.item
track_info = f"Track: {getattr(item, 'title', 'Unknown')} (ID: {item.id})" track_info = f"Track: {getattr(item, 'title', 'Unknown')} (ID: {item.id})"
ctx.obj.console.print(f"[red]Error:[/] {e} ({track_info})") ctx.obj.console.print(f"[red]Error:[/] {e} ({track_info})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
offset += mix_items.limit offset += mix_items.limit
@@ -500,11 +500,11 @@ def download_callback(
await download_album(album) await download_album(album)
except ApiError as e: except ApiError as e:
ctx.obj.console.print(f"[red]API Error:[/] {e} (Album: {album.title}, ID: {album.id})") ctx.obj.console.print(f"[red]API Error:[/] {e} (Album: {album.title}, ID: {album.id})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
except Exception as e: except Exception as e:
ctx.obj.console.print(f"[red]Error:[/] {e} (Album: {album.title}, ID: {album.id})") ctx.obj.console.print(f"[red]Error:[/] {e} (Album: {album.title}, ID: {album.id})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
def get_all_albums(singles: bool): def get_all_albums(singles: bool):
@@ -554,11 +554,11 @@ def download_callback(
) )
except ApiError as e: except ApiError as e:
ctx.obj.console.print(f"[red]API Error:[/] {e} (Video: {video.title}, ID: {video.id})") ctx.obj.console.print(f"[red]API Error:[/] {e} (Video: {video.title}, ID: {video.id})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
except Exception as e: except Exception as e:
ctx.obj.console.print(f"[red]Error:[/] {e} (Video: {video.title}, ID: {video.id})") ctx.obj.console.print(f"[red]Error:[/] {e} (Video: {video.title}, ID: {video.id})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
if offset > artist_videos.totalNumberOfItems: if offset > artist_videos.totalNumberOfItems:
@@ -621,13 +621,13 @@ def download_callback(
if hasattr(item, 'album') and item.album: if hasattr(item, 'album') and item.album:
track_info += f", Album ID: {item.album.id}" track_info += f", Album ID: {item.album.id}"
ctx.obj.console.print(f"[red]API Error:[/] {e} ({track_info})") ctx.obj.console.print(f"[red]API Error:[/] {e} ({track_info})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
except Exception as e: except Exception as e:
item = playlist_item.item item = playlist_item.item
track_info = f"Track: {getattr(item, 'title', 'Unknown')} (ID: {item.id})" track_info = f"Track: {getattr(item, 'title', 'Unknown')} (ID: {item.id})"
ctx.obj.console.print(f"[red]Error:[/] {e} ({track_info})") ctx.obj.console.print(f"[red]Error:[/] {e} ({track_info})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
offset += playlist_items.limit offset += playlist_items.limit
@@ -673,11 +673,11 @@ def download_callback(
await handle_resource(r) await handle_resource(r)
except ApiError as e: except ApiError as e:
ctx.obj.console.print(f"[red]API Error:[/] {e} ({r})") ctx.obj.console.print(f"[red]API Error:[/] {e} ({r})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
except Exception as e: except Exception as e:
ctx.obj.console.print(f"[red]Error:[/] {e} ({r})") ctx.obj.console.print(f"[red]Error:[/] {e} ({r})")
if not SKIP_ERRORS: if RAISE_ERRORS:
raise raise
await asyncio.gather(*(wrapper(r) for r in ctx.obj.resources)) await asyncio.gather(*(wrapper(r) for r in ctx.obj.resources))