GitHub/outline
1
0
Fork 0
mirror of https://github.com/outline/outline.git synced 2026-06-13 11:25:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Flaky test ordered event expectations (#8607)

Browse Source
This commit is contained in:
Tom Moor
2025-03-02 08:21:25 -05:00
committed by GitHub
parent 82cdebfb66
commit 237253afdb
1 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/queues/tasks/RevisionCreatedNotificationsTask.test.ts
+15 -16
View File
@@ -169,14 +169,14 @@ describe("revisions.create", () => {
// Should emit 3 `subscriptions.create` events.
expect(events.length).toEqual(3);
expect(events[0].name).toEqual("subscriptions.create");
expect(events[1].name).toEqual("subscriptions.create");
expect(events[2].name).toEqual("subscriptions.create");
expect(
events.every((event) => event.name === "subscriptions.create")
).toEqual(true);
// Each event should point to same document.
expect(events[0].documentId).toEqual(document.id);
expect(events[1].documentId).toEqual(document.id);
expect(events[2].documentId).toEqual(document.id);
expect(events.every((event) => event.documentId === document.id)).toEqual(
true
);
// Events should mention correct `userId`.
const userIds = events.map((event) => event.userId);
@@ -272,16 +272,15 @@ describe("revisions.create", () => {
// Should emit 2 `subscriptions.create` events.
expect(events.length).toEqual(2);
expect(events[0].name).toEqual("subscriptions.create");
expect(events[1].name).toEqual("subscriptions.create");
// Each event should point to same document.
expect(events[0].documentId).toEqual(document.id);
expect(events[1].documentId).toEqual(document.id);
// Events should mention correct `userId`.
expect(events[0].userId).toEqual(collaborator0.id);
expect(events[1].userId).toEqual(collaborator1.id);
expect(events.every((event) => event.documentId === document.id)).toEqual(
true
);
expect(events.some((event) => event.userId === collaborator0.id)).toEqual(
true
);
expect(events.some((event) => event.userId === collaborator1.id)).toEqual(
true
);
// One notification as one collaborator performed edit and the other is
// unsubscribed