mirror of
https://github.com/outline/outline.git
synced 2026-06-13 11:25:03 +03:00
Restore SidebarButton position default to fix top padding regression (#12618)
The position prop is omitted at several call sites (App, Settings, Shared sidebars) and relied on the top default for inset-titlebar padding. Make the prop optional and restore the default so the lint rule stays satisfied without changing runtime behavior. Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -11,7 +11,7 @@ import Desktop from "~/utils/Desktop";
|
||||
import { HStack } from "~/components/primitives/HStack";
|
||||
|
||||
export type SidebarButtonProps = React.ComponentProps<typeof Button> & {
|
||||
position: "top" | "bottom";
|
||||
position?: "top" | "bottom";
|
||||
title: React.ReactNode;
|
||||
image: React.ReactNode;
|
||||
showMoreMenu?: boolean;
|
||||
@@ -23,7 +23,7 @@ const SidebarButton = observer(
|
||||
React.forwardRef<HTMLButtonElement, SidebarButtonProps>(
|
||||
function SidebarButton_(
|
||||
{
|
||||
position,
|
||||
position = "top",
|
||||
showMoreMenu,
|
||||
image,
|
||||
title,
|
||||
|
||||
Reference in New Issue
Block a user