GitHub/outline
1
0
Fork 0
mirror of https://github.com/outline/outline.git synced 2026-06-13 11:25:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Correct TypeScript types for Logger calls in GitHub plugin

Browse Source 
- Wrap unknown error objects in { error: err } for Logger.debug and Logger.warn calls
- Ensures compatibility with Logger's Extra type parameter requirements
- Fixes TypeScript compilation errors in CI
This commit is contained in:
codegen-sh[bot]
2025-09-04 02:04:41 +00:00
parent 2c7a365541
commit ae04635e42
1 changed files with 22 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/github/server/github.ts
+22 -14
View File
@@ -242,16 +242,17 @@ export class GitHub {
// Fallback: Try to fetch public repository data using GitHub's public API
try {
const appClient = GitHub.authenticateAsApp();
const publicData = await GitHub.fetchPublicResource(resource, appClient);
const publicData = await GitHub.fetchPublicResource(
resource,
appClient
);
if (publicData) {
return GitHub.transformData(publicData, resource.type);
}
} catch (err: unknown) {
Logger.debug(
"plugins",
"Failed to fetch public resource from GitHub",
err
);
Logger.debug("plugins", "Failed to fetch public resource from GitHub", {
error: err,
});
}
return;
}
@@ -268,11 +269,12 @@ export class GitHub {
return GitHub.transformData(res.data, resource.type);
} catch (err: unknown) {
Logger.warn("Failed to fetch resource from GitHub", err);
return {
error: err && typeof err === 'object' && 'message' in err
? (err.message as string) || "Unknown error"
: "Unknown error"
Logger.warn("Failed to fetch resource from GitHub", { error: err });
return {
error:
err && typeof err === "object" && "message" in err
? (err.message as string) || "Unknown error"
: "Unknown error",
};
}
};
@@ -326,11 +328,17 @@ export class GitHub {
}
} catch (err: unknown) {
// Handle common error cases
if (err && typeof err === 'object' && 'status' in err) {
if (err && typeof err === "object" && "status" in err) {
if (err.status === 404) {
Logger.debug("plugins", `GitHub resource not found or private: ${resource.owner}/${resource.repo}#${resource.id}`);
Logger.debug(
"plugins",
`GitHub resource not found or private: ${resource.owner}/${resource.repo}#${resource.id}`
);
} else if (err.status === 403) {
Logger.debug("plugins", `GitHub API rate limit exceeded or access denied: ${resource.owner}/${resource.repo}#${resource.id}`);
Logger.debug(
"plugins",
`GitHub API rate limit exceeded or access denied: ${resource.owner}/${resource.repo}#${resource.id}`
);
}
}
return null;