GitHub/outline
1
0
Fork 0
mirror of https://github.com/outline/outline.git synced 2026-06-13 11:25:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Flaky i18n test from repeated singleton re-initialization (#11999)

Browse Source 
* fix: Flaky i18n test from repeated singleton re-initialization

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: Remove redundant initI18n call, rely on global test setup

initI18n() is already called in app/test/setup.ts for all app tests.
The extra call in beforeAll could re-introduce the same race condition.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Tom Moor
2026-04-10 12:19:00 -04:00
committed by GitHub
parent 79df2f2dc8
commit c6a1db6bd1
1 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/utils/i18n.test.ts
+4 -11
View File
@@ -2,19 +2,18 @@ import i18n from "i18next";
import de_DE from "../../shared/i18n/locales/de_DE/translation.json";
import en_US from "../../shared/i18n/locales/en_US/translation.json";
import pt_PT from "../../shared/i18n/locales/pt_PT/translation.json";
import { initI18n } from "./i18n";
function addResources() {
// i18n is already initialized globally via app/test/setup.ts — only add
// test resources here, without re-initializing the singleton.
beforeAll(() => {
i18n
.addResources("en-US", "translation", en_US)
.addResources("de-DE", "translation", de_DE)
.addResources("pt-PT", "translation", pt_PT);
}
});
describe("i18n env is unset", () => {
beforeEach(async () => {
initI18n();
addResources();
await i18n.changeLanguage("en-US");
});
@@ -34,8 +33,6 @@ describe("i18n env is unset", () => {
describe("i18n env is en-US", () => {
beforeEach(async () => {
initI18n("en-US");
addResources();
await i18n.changeLanguage("en-US");
});
@@ -55,8 +52,6 @@ describe("i18n env is en-US", () => {
describe("i18n env is de-DE", () => {
beforeEach(async () => {
initI18n("de-DE");
addResources();
await i18n.changeLanguage("de-DE");
});
@@ -76,8 +71,6 @@ describe("i18n env is de-DE", () => {
describe("i18n env is pt-PT", () => {
beforeEach(async () => {
initI18n("pt-PT");
addResources();
await i18n.changeLanguage("pt-PT");
});