Fix event timestamp issue: remove createdAt from revision creation

Events should reflect the time they are recorded in the database, not the model's creation time.
The revision model itself can still have its createdAt set to document.updatedAt, but the event
should use the current database time when it's created.

server/commands/revisionCreator.ts

@@ -1,4 +1,5 @@
-import { Document, User, Event, Revision } from "@server/models";
+import { createContext } from "@server/context";
+import { Document, User, Revision } from "@server/models";
 import { sequelize } from "@server/storage/database";
 import { DocumentEvent, RevisionEvent } from "@server/types";
 
@@ -12,25 +13,13 @@ export default async function revisionCreator({
   user: User;
 }) {
   return sequelize.transaction(async (transaction) => {
-    const revision = await Revision.createFromDocument(document, {
+    const ctx = createContext({
+      user,
+      authType: event.authType,
+      ip: event.ip ?? user.lastActiveIp,
       transaction,
     });
-    await Event.create(
-      {
-        name: "revisions.create",
-        documentId: document.id,
-        collectionId: document.collectionId,
-        modelId: revision.id,
-        teamId: document.teamId,
-        actorId: user.id,
-        createdAt: document.updatedAt,
-        ip: event.ip ?? user.lastActiveIp,
-        authType: event.authType,
-      },
-      {
-        transaction,
-      }
-    );
-    return revision;
+
+    return Revision.createFromDocumentWithCtx(ctx, document);
   });
 }

server/models/Revision.ts

@@ -17,6 +17,7 @@ import {
 } from "sequelize-typescript";
 import type { ProsemirrorData } from "@shared/types";
 import { DocumentValidation, RevisionValidation } from "@shared/validations";
+import { APIContext } from "@server/types";
 import Document from "./Document";
 import User from "./User";
 import ParanoidModel from "./base/ParanoidModel";
@@ -39,6 +40,7 @@ class Revision extends ParanoidModel<
   InferAttributes<Revision>,
   Partial<InferCreationAttributes<Revision>>
 > {
+  static eventNamespace = "revisions";
   @IsNumeric
   @Column(DataType.SMALLINT)
   version?: number | null;
@@ -173,6 +175,26 @@ class Revision extends ParanoidModel<
     return revision.save(options);
   }
 
+  /**
+   * Create a Revision model from a Document model with context for auto event creation
+   *
+   * @param ctx The API context
+   * @param document The document to create from
+   * @returns A Promise that resolves to the created revision
+   */
+  static createFromDocumentWithCtx(ctx: APIContext, document: Document) {
+    return this.createWithCtx(ctx, {
+      title: document.title,
+      icon: document.icon,
+      color: document.color,
+      content: document.content,
+      userId: document.lastModifiedById,
+      editorVersion: document.editorVersion,
+      version: document.version,
+      documentId: document.id,
+    });
+  }
+
   // instance methods
 
   /**

server/models/base/Model.ts

@@ -270,6 +270,7 @@ class Model<
       ip: context.ip,
       changes: model.previousChangeset,
       data: context.event.data,
+      createdAt: "createdAt" in model ? model.createdAt : undefined,
     };
 
     if (context.event?.persist !== false) {

server/routes/api/revisions/revisions.ts

@@ -84,7 +84,7 @@ router.post(
     authorize(user, "update", revision);
 
     revision.name = name;
-    await revision.save({ transaction });
+    await revision.saveWithCtx(ctx, { transaction });
 
     ctx.body = {
       data: await presentRevision(revision),