mirror of
https://github.com/outline/outline.git
synced 2026-06-13 03:14:59 +03:00
091346dfe8
* wip * Remove obsolete snapshots * simplify * chore(test): Convert mocks to TypeScript and tighten fetch mock types Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Remove unneccessary patches * Migrate to msw instead of custom fetch mock * Address PR review comments - Split chained vi.useFakeTimers().setSystemTime() into separate calls. - Switch test setup to dynamic imports so EventEmitter.defaultMaxListeners assignment runs before module init (static imports were hoisted above it). - Drop redundant NODE_ENV guard in monkeyPatchSequelizeErrorsForJest; its sole caller already gates on env.isTest. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
432 lines
13 KiB
TypeScript
432 lines
13 KiB
TypeScript
import { FileOperationState, FileOperationType } from "@shared/types";
|
|
import { Collection, User, Event, FileOperation } from "@server/models";
|
|
import {
|
|
buildAdmin,
|
|
buildCollection,
|
|
buildFileOperation,
|
|
buildTeam,
|
|
buildUser,
|
|
} from "@server/test/factories";
|
|
|
|
import { getTestServer } from "@server/test/support";
|
|
|
|
const server = getTestServer();
|
|
|
|
vi.mock("@server/storage/files");
|
|
|
|
describe("#fileOperations.info", () => {
|
|
it("should return fileOperation", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({
|
|
teamId: team.id,
|
|
});
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.info", {
|
|
body: {
|
|
id: exportData.id,
|
|
token: admin.getJwtToken(),
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
expect(res.status).toEqual(200);
|
|
expect(body.data.id).toBe(exportData.id);
|
|
expect(body.data.state).toBe(exportData.state);
|
|
});
|
|
|
|
it("should allow user to read their own export", async () => {
|
|
const team = await buildTeam();
|
|
const user = await buildUser({ teamId: team.id });
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: user.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.info", {
|
|
body: {
|
|
id: exportData.id,
|
|
token: user.getJwtToken(),
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
expect(res.status).toEqual(200);
|
|
expect(body.data.id).toBe(exportData.id);
|
|
});
|
|
|
|
it("should not allow user to read another user's export", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({ teamId: team.id });
|
|
const user = await buildUser({ teamId: team.id });
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.info", {
|
|
body: {
|
|
id: exportData.id,
|
|
token: user.getJwtToken(),
|
|
},
|
|
});
|
|
expect(res.status).toEqual(403);
|
|
});
|
|
|
|
it("should allow admin to read another admin's export", async () => {
|
|
const team = await buildTeam();
|
|
const admin1 = await buildAdmin({ teamId: team.id });
|
|
const admin2 = await buildAdmin({ teamId: team.id });
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin1.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.info", {
|
|
body: {
|
|
id: exportData.id,
|
|
token: admin2.getJwtToken(),
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
expect(res.status).toEqual(200);
|
|
expect(body.data.id).toBe(exportData.id);
|
|
});
|
|
|
|
it("should allow admin to read an import file operation", async () => {
|
|
const team = await buildTeam();
|
|
const admin1 = await buildAdmin({ teamId: team.id });
|
|
const admin2 = await buildAdmin({ teamId: team.id });
|
|
const importOp = await buildFileOperation({
|
|
type: FileOperationType.Import,
|
|
teamId: team.id,
|
|
userId: admin1.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.info", {
|
|
body: {
|
|
id: importOp.id,
|
|
token: admin2.getJwtToken(),
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
expect(res.status).toEqual(200);
|
|
expect(body.data.id).toBe(importOp.id);
|
|
});
|
|
|
|
it("should require authorization", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin();
|
|
await buildUser({
|
|
teamId: team.id,
|
|
});
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.info", {
|
|
body: {
|
|
id: exportData.id,
|
|
token: admin.getJwtToken(),
|
|
},
|
|
});
|
|
expect(res.status).toEqual(403);
|
|
});
|
|
});
|
|
|
|
describe("#fileOperations.list", () => {
|
|
it("should return fileOperations list", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({
|
|
teamId: team.id,
|
|
});
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.list", {
|
|
body: {
|
|
token: admin.getJwtToken(),
|
|
type: FileOperationType.Export,
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
const data = body.data[0];
|
|
expect(res.status).toEqual(200);
|
|
expect(body.data.length).toBe(1);
|
|
expect(data.id).toBe(exportData.id);
|
|
expect(data.key).toBe(undefined);
|
|
expect(data.state).toBe(exportData.state);
|
|
});
|
|
|
|
it("should return exports with collection data", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({
|
|
teamId: team.id,
|
|
});
|
|
const collection = await buildCollection({
|
|
userId: admin.id,
|
|
teamId: team.id,
|
|
});
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
collectionId: collection.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.list", {
|
|
body: {
|
|
token: admin.getJwtToken(),
|
|
type: FileOperationType.Export,
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
const data = body.data[0];
|
|
expect(res.status).toEqual(200);
|
|
expect(body.data.length).toBe(1);
|
|
expect(data.id).toBe(exportData.id);
|
|
expect(data.key).toBe(undefined);
|
|
expect(data.state).toBe(exportData.state);
|
|
expect(data.collectionId).toBe(collection.id);
|
|
});
|
|
|
|
it("should return exports with collection data even if collection is deleted", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({
|
|
teamId: team.id,
|
|
});
|
|
const collection = await buildCollection({
|
|
userId: admin.id,
|
|
teamId: team.id,
|
|
});
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
collectionId: collection.id,
|
|
});
|
|
await collection.destroy({ hooks: false });
|
|
const isCollectionPresent = await Collection.findByPk(collection.id);
|
|
expect(isCollectionPresent).toBe(null);
|
|
const res = await server.post("/api/fileOperations.list", {
|
|
body: {
|
|
token: admin.getJwtToken(),
|
|
type: FileOperationType.Export,
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
const data = body.data[0];
|
|
expect(res.status).toEqual(200);
|
|
expect(body.data.length).toBe(1);
|
|
expect(data.id).toBe(exportData.id);
|
|
expect(data.key).toBe(undefined);
|
|
expect(data.state).toBe(exportData.state);
|
|
expect(data.collectionId).toBe(collection.id);
|
|
});
|
|
|
|
it("should return exports with user data even if user is deleted", async () => {
|
|
const team = await buildTeam();
|
|
const admin2 = await buildAdmin({
|
|
teamId: team.id,
|
|
});
|
|
const admin = await buildAdmin({
|
|
teamId: team.id,
|
|
});
|
|
const collection = await buildCollection({
|
|
userId: admin.id,
|
|
teamId: team.id,
|
|
});
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
collectionId: collection.id,
|
|
});
|
|
await admin.destroy();
|
|
const isAdminPresent = await User.findByPk(admin.id);
|
|
expect(isAdminPresent).toBe(null);
|
|
const res = await server.post("/api/fileOperations.list", {
|
|
body: {
|
|
token: admin2.getJwtToken(),
|
|
type: FileOperationType.Export,
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
const data = body.data[0];
|
|
expect(res.status).toEqual(200);
|
|
expect(body.data.length).toBe(1);
|
|
expect(data.id).toBe(exportData.id);
|
|
expect(data.key).toBe(undefined);
|
|
expect(data.state).toBe(exportData.state);
|
|
expect(data.user.id).toBe(admin.id);
|
|
});
|
|
|
|
it("should require admin", async () => {
|
|
const user = await buildUser();
|
|
const res = await server.post("/api/fileOperations.list", {
|
|
body: {
|
|
token: user.getJwtToken(),
|
|
type: FileOperationType.Export,
|
|
},
|
|
});
|
|
expect(res.status).toEqual(403);
|
|
});
|
|
});
|
|
|
|
describe("#fileOperations.redirect", () => {
|
|
it("should not redirect when file operation is not complete", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({
|
|
teamId: team.id,
|
|
});
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.redirect", {
|
|
body: {
|
|
token: admin.getJwtToken(),
|
|
id: exportData.id,
|
|
},
|
|
});
|
|
const body = await res.json();
|
|
expect(res.status).toEqual(400);
|
|
expect(body.message).toEqual("export is not complete yet");
|
|
});
|
|
|
|
it("should allow admin to redirect another admin's export", async () => {
|
|
const team = await buildTeam();
|
|
const admin1 = await buildAdmin({ teamId: team.id });
|
|
const admin2 = await buildAdmin({ teamId: team.id });
|
|
const exportData = await buildFileOperation({
|
|
state: FileOperationState.Complete,
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin1.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.redirect", {
|
|
body: {
|
|
token: admin2.getJwtToken(),
|
|
id: exportData.id,
|
|
},
|
|
redirect: "manual",
|
|
});
|
|
expect(res.status).toEqual(302);
|
|
});
|
|
|
|
it("should allow user to redirect their own export", async () => {
|
|
const team = await buildTeam();
|
|
const user = await buildUser({ teamId: team.id });
|
|
const exportData = await buildFileOperation({
|
|
state: FileOperationState.Complete,
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: user.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.redirect", {
|
|
body: {
|
|
token: user.getJwtToken(),
|
|
id: exportData.id,
|
|
},
|
|
redirect: "manual",
|
|
});
|
|
expect(res.status).toEqual(302);
|
|
});
|
|
|
|
it("should not allow user to redirect another user's export", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({ teamId: team.id });
|
|
const user = await buildUser({ teamId: team.id });
|
|
const exportData = await buildFileOperation({
|
|
state: FileOperationState.Complete,
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.redirect", {
|
|
body: {
|
|
token: user.getJwtToken(),
|
|
id: exportData.id,
|
|
},
|
|
});
|
|
expect(res.status).toEqual(403);
|
|
});
|
|
|
|
it("should require authorization", async () => {
|
|
const team = await buildTeam();
|
|
const user = await buildUser({ teamId: team.id });
|
|
const admin = await buildAdmin();
|
|
const exportData = await buildFileOperation({
|
|
state: FileOperationState.Complete,
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: user.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.redirect", {
|
|
body: {
|
|
token: admin.getJwtToken(),
|
|
id: exportData.id,
|
|
},
|
|
});
|
|
expect(res.status).toEqual(403);
|
|
});
|
|
});
|
|
|
|
describe("#fileOperations.delete", () => {
|
|
it("should delete file operation", async () => {
|
|
const team = await buildTeam();
|
|
const admin = await buildAdmin({
|
|
teamId: team.id,
|
|
});
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: admin.id,
|
|
state: FileOperationState.Complete,
|
|
});
|
|
const deleteResponse = await server.post("/api/fileOperations.delete", {
|
|
body: {
|
|
token: admin.getJwtToken(),
|
|
id: exportData.id,
|
|
},
|
|
});
|
|
expect(deleteResponse.status).toBe(200);
|
|
expect(
|
|
await Event.count({
|
|
where: {
|
|
name: "fileOperations.delete",
|
|
teamId: team.id,
|
|
},
|
|
})
|
|
).toBe(1);
|
|
expect(
|
|
await FileOperation.count({
|
|
where: {
|
|
teamId: team.id,
|
|
},
|
|
})
|
|
).toBe(0);
|
|
});
|
|
|
|
it("should require authorization", async () => {
|
|
const team = await buildTeam();
|
|
const user = await buildUser({ teamId: team.id });
|
|
const admin = await buildAdmin();
|
|
const exportData = await buildFileOperation({
|
|
type: FileOperationType.Export,
|
|
teamId: team.id,
|
|
userId: user.id,
|
|
});
|
|
const res = await server.post("/api/fileOperations.delete", {
|
|
body: {
|
|
token: admin.getJwtToken(),
|
|
id: exportData.id,
|
|
},
|
|
});
|
|
expect(res.status).toEqual(403);
|
|
});
|
|
});
|