mirror of
https://github.com/outline/outline.git
synced 2026-06-13 11:25:03 +03:00
Tom Moor
5ea63aa1a2
* fix: Block math not closed by trailing $$ on a content line The closing delimiter check compared a 3-character slice against the 2-character "$$" delimiter, so block math closed on the same line as content (e.g. "c = d$$") was never detected and the block swallowed the rest of the document. Use the delimiter length rather than a hardcoded slice. Also fix the indexOf sentinel comparison (!== 1 instead of !== -1) in inline math parsing, which terminated correctly only by coincidence. Adds tests for the math markdown rules and moves the findNodes test helper into shared/test/editor for reuse. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: NaN width and height parsed for video and image nodes Video parseDOM and parseMarkdown used parseInt on a missing attribute, storing NaN instead of null and persisting it to markdown as NaNxNaN. Image size syntax with a missing dimension (e.g. "=x100") hit the same issue through optional regex groups. Parse dimensions only when present, matching the existing guard in Image parseDOM, and correct the video getAttrs element type. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: Normalize non-numeric video dimensions, avoid serializing nullxnull Review feedback: parseInt could still produce NaN when the attribute exists but is not numeric (e.g. width="auto"), and toMarkdown wrote null dimensions as "nullxnull". Parse dimensions through a helper that normalizes non-finite values to null, and serialize nullish dimensions as empty strings, which still round-trips as a video node. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
51 lines
1.8 KiB
TypeScript
51 lines
1.8 KiB
TypeScript
import type { JSONNode } from "../../test/editor";
|
|
import { extensionManager, findNodes, schema } from "../../test/editor";
|
|
|
|
const parser = extensionManager.parser({
|
|
schema,
|
|
plugins: extensionManager.rulePlugins,
|
|
});
|
|
|
|
const parseToJSON = (markdown: string): JSONNode | undefined =>
|
|
parser.parse(markdown)?.toJSON();
|
|
|
|
describe("math markdown rules", () => {
|
|
it("parses inline math", () => {
|
|
const doc = parseToJSON("before $x + y$ after");
|
|
const nodes = findNodes(doc, "math_inline");
|
|
|
|
expect(nodes).toHaveLength(1);
|
|
expect(nodes[0].content?.[0].text).toBe("x + y");
|
|
});
|
|
|
|
it("parses block math with closing delimiter on its own line", () => {
|
|
const doc = parseToJSON("$$\na = b\n$$\n\nparagraph after");
|
|
const nodes = findNodes(doc, "math_block");
|
|
|
|
expect(nodes).toHaveLength(1);
|
|
expect(nodes[0].content?.[0].text).toContain("a = b");
|
|
expect(findNodes(doc, "paragraph")).toHaveLength(1);
|
|
});
|
|
|
|
it("parses block math with closing delimiter at the end of a content line", () => {
|
|
const doc = parseToJSON("$$\na = b\nc = d$$\n\nparagraph after");
|
|
const blocks = findNodes(doc, "math_block");
|
|
|
|
expect(blocks).toHaveLength(1);
|
|
expect(blocks[0].content?.[0].text).toContain("a = b");
|
|
expect(blocks[0].content?.[0].text).toContain("c = d");
|
|
|
|
// The paragraph following the block must not be swallowed into the math
|
|
const paragraphs = findNodes(doc, "paragraph");
|
|
expect(paragraphs).toHaveLength(1);
|
|
expect(blocks[0].content?.[0].text).not.toContain("paragraph after");
|
|
});
|
|
|
|
it("leaves unclosed inline math as plain text", () => {
|
|
const doc = parseToJSON("price is $5 and rising");
|
|
|
|
expect(findNodes(doc, "math_inline")).toHaveLength(0);
|
|
expect(findNodes(doc, "math_block")).toHaveLength(0);
|
|
});
|
|
});
|